Rewrite flash attention workflow to avoid using GH container #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Credit to Claude code Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn
changed the title
Signed-off-by: Huy Do <huydhn@gmail.com>
|
Some notes I have while debugging the issue:
|
jduprat
approved these changes
Aug 5, 2025
| export PYTHONPATH=$(pwd) | ||
| python benchmarks/benchmark_attn.py >> $GITHUB_STEP_SUMMARY | ||
| echo '<h1>B200 1000W</h1>' >> /tmp/workspace/fa4_output.txt | ||
| nvidia-smi >> /tmp/workspace/fa4_output.txt |
There was a problem hiding this comment.
The output of nvidia-smi makes the output hard to read. I prefer that we run it (so I can check the logs and confirm we are on the right class of machine) without piping into /tmp/workspace/fa4_output.txt
There was a problem hiding this comment.
Oh, I can remove this quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub container doesn't work with multi-tenant rootless Docker in Docker setup https://github.com/pytorch/pytorch-integration-testing/actions/runs/16742012333/job/47392166734, maybe we want to look closer into this to understand the why.
I'm rewriting the workflow to call Docker directly. Credit to Claude code.