Turn on capture_dynamic_output_shape_ops/capture_scalar_outputs by default for export #105962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault for export Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
tugsbayasgalan
approved these changes
Jul 26, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge -f "everything clear" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot drci |
BowenBao
added a commit
that referenced
this pull request
Jul 28, 2023
…ar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…m number representing scalar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…nting scalar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…epresenting scalar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…ar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…port type promoting sym number representing scalar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 1, 2023
…ing sym number representing scalar output" Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…106178) Summary: * Add test cases distilled from models that requires setting dynamo config `capture_scalar_outputs` and `capture_dynamic_output_shape_ops` to True. Kudos to #105962 both configs are on by default for export now. * Improve type promotion to support fx.Node of sym number representing scalar output. * Bug fix: `onnxfunction_dispatcher` would crash if an input was mis-aligned to be attribute when doing schema matching. * Misc: re-enable op tests that are already passing. * Needs microsoft/onnxscript#931. Waiting for merge and the publishing of the new whl. Pull Request resolved: #106178 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms, https://github.com/thiagocrepaldi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov