Use ATen native functions for THCTensor_cadd/cmul/cdiv/csub #10707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to save a few percent in binary size in libcaffe2_gpu.so, but the effect may not be real. In fact, deleting some functions can cause the binary size to increase (perhaps due to alignment issues).
colesbury
requested review from
apaszke,
ezyang,
gchanan,
soumith and
zdevito
as code owners
There was a problem hiding this comment.
colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
reviewed
Aug 21, 2018
| if (ndim == 2) | ||
| { | ||
| THCTensor_(sum)(state, gradWeightBuf, gradInput, 0, 1); | ||
| THCTensor_(sum)(state, gradWeightBuf, gradInput, 0, 0); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
||
| THCudaCheck(cudaGetLastError()); | ||
| auto out = at::Tensor(self_, true); | ||
| at::div_out(out, at::Tensor(src1, true), at::Tensor(src2, true)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 23, 2018
Summary: This seems to save a few percent in binary size in libcaffe2_gpu.so, but the effect may not be real. In fact, deleting some functions can cause the binary size to increase (perhaps due to alignment issues). cc orionr Pull Request resolved: pytorch/pytorch#10707 Differential Revision: D9409009 Pulled By: colesbury fbshipit-source-id: 282931e562e84e316a33ac6da4788c04c2984f08
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…10707) Summary: This seems to save a few percent in binary size in libcaffe2_gpu.so, but the effect may not be real. In fact, deleting some functions can cause the binary size to increase (perhaps due to alignment issues). cc orionr Pull Request resolved: pytorch#10707 Differential Revision: D9409009 Pulled By: colesbury fbshipit-source-id: 282931e562e84e316a33ac6da4788c04c2984f08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to save a few percent in binary size in libcaffe2_gpu.so, but
the effect may not be real. In fact, deleting some functions can cause
the binary size to increase (perhaps due to alignment issues).
cc @orionr