[dtensor] fix new_empty_strided op #107835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107835
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6500af9 with merge base e68b3ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Aug 24, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax ghstack-source-id: 47f7b6b Pull Request resolved: #107835
fduwjj
reviewed
Aug 25, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Aug 25, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax ghstack-source-id: e472c3b Pull Request resolved: #107835
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Aug 26, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax ghstack-source-id: ff53107 Pull Request resolved: #107835
fduwjj
approved these changes
Aug 26, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Aug 31, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax ghstack-source-id: 0c827b9 Pull Request resolved: #107835
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wanchaol
added a commit
that referenced
this pull request
Sep 5, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax Pull Request resolved: #107835 Approved by: https://github.com/fduwjj
This was referenced Sep 5, 2023
atalman
pushed a commit
that referenced
this pull request
Sep 6, 2023
This PR fixes the new_empty_strided op to become replicate from sharding when necessary, this is a quick fix to resolve #107661 We'll need to think more about the behavior of this op when it comes to sharding, one possibility is to follow the input sharding, but given the output shape of this op might not be the same as the input, it's hard to say we should follow the input sharding, further improvement needed once we figure out the op syntax Pull Request resolved: #107835 Approved by: https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR fixes the new_empty_strided op to become replicate from sharding
when necessary, this is a quick fix to resolve #107661
We'll need to think more about the behavior of this op when it comes to
sharding, one possibility is to follow the input sharding, but given the
output shape of this op might not be the same as the input, it's hard to
say we should follow the input sharding, further improvement needed once
we figure out the op syntax