Skip to content

[quant][executorch] Support inception_v4 in examples #108382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[quant][executorch] Support inception_v4 in examples #108382

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor

Summary: Verified that pt2e quant flow matches the fx flow with executorch backend config

Test Plan:
with-proxy buck2 run executorch/examples/quantization:example -- -m=ic4 --verify

[INFO 2023-08-31 16:08:06,923 example.py:77] prepare sqnr: inf
[INFO 2023-08-31 16:08:06,932 example.py:81] quant diff max: 0.0
[INFO 2023-08-31 16:08:06,936 example.py:85] quant sqnr: inf

full output: https://www.internalfb.com/intern/paste/P818520579/

Differential Revision: D48889075

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108382

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit 6b9446e with merge base 30a33b7 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the release notes: quantization release notes category label Aug 31, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

kimishpatel
kimishpatel approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Accepting for now, but it would be good to add test for this.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

@jerryzh168
Copy link
Contributor Author

Looks good. Accepting for now, but it would be good to add test for this.

sure I can add a test after refactoring test code, right now it is tested in executorch

This was referenced Sep 1, 2023
Closed
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

@jerryzh168 @facebook-github-bot
[quant][executorch] Support inception_v4 in examples (pytorch#108382)
6b9446e 
Summary:
X-link: pytorch/executorch#203


Verified that pt2e quant flow matches the fx flow with executorch backend config

Test Plan:
with-proxy buck2 run executorch/examples/quantization:example -- -m=ic4 --verify

```
[INFO 2023-08-31 16:08:06,923 example.py:77] prepare sqnr: inf
[INFO 2023-08-31 16:08:06,932 example.py:81] quant diff max: 0.0
[INFO 2023-08-31 16:08:06,936 example.py:85] quant sqnr: inf
```

full output: https://www.internalfb.com/intern/paste/P818520579/

Reviewed By: kimishpatel

Differential Revision: D48889075
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48889075

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Sep 8, 2023
@jerryzh168 @facebook-github-bot
Support inception_v4 in examples (#203)
5e6e437 
Summary:
Pull Request resolved: #203

X-link: pytorch/pytorch#108382

Verified that pt2e quant flow matches the fx flow with executorch backend config

bypass-github-export-checks

Reviewed By: kimishpatel

Differential Revision: D48889075

fbshipit-source-id: 40bcad1f32354131cf8d1194dca31b9d13dd6011
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

@mcr229 mcr229 Awaiting requested review from mcr229

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

Assignees
No one assigned
Labels
fb-exported Merged release notes: AO frontend release notes: quantization release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerryzh168 @facebook-github-bot @pytorchmergebot @kimishpatel