Skip to content

[Decomposition] _unsafe_view #108713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Decomposition] _unsafe_view #108713

wants to merge 1 commit into from

Conversation

salilsdesai
Copy link
Contributor

@salilsdesai salilsdesai commented Sep 6, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108713

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 694b6b6 with merge base 70ca3ee (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 7, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
5d0ec7b 
Summary:

Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 8, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
c87416f 
Summary:

Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

SherlockNoMad
SherlockNoMad approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@SherlockNoMad SherlockNoMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 14, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
afecc49 
Summary:

Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

peterbell10
peterbell10 reviewed Sep 14, 2023
View reviewed changes
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 15, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
27e19ec 
Summary:

Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Reviewed By: SS-JIA

Differential Revision: D48619079
salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 16, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
5a16262 
Summary:
bypass-github-pytorch-ci-checks


Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Reviewed By: SS-JIA

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 17, 2023
@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
46f3596 
Summary:
bypass-github-pytorch-ci-checks


Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Reviewed By: SS-JIA

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@salilsdesai @facebook-github-bot
[Decomposition] _unsafe_view (pytorch#108713)
694b6b6 
Summary:
bypass-github-pytorch-ci-checks


Decomp already exists so just add it to core_aten_decompositions

https://www.internalfb.com/code/fbsource/[9d5eabd7b213d1a356d4e7bb400355d574ea924b]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=3091

Test Plan: Phabricator + OSS Tests

Reviewed By: SS-JIA

Differential Revision: D48619079
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48619079

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 19, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eellison eellison mentioned this pull request Sep 20, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 20, 2023
@eellison @pytorchmergebot
add back in unsafe view decomp (#109663)
76dd38b 
This decomp makes pattern matching easier, and was only just excluded from decomp set in #108713

Pull Request resolved: #109663
Approved by: https://github.com/davidberard98, https://github.com/yanboliang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbell10 peterbell10 peterbell10 left review comments

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@salilsdesai @facebook-github-bot @pytorchmergebot @larryliu0820 @SherlockNoMad @peterbell10