Skip to content

[inductor][Optimus]Improve logging for group batch fusion #109314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[inductor][Optimus]Improve logging for group batch fusion #109314

wants to merge 1 commit into from

Conversation

jackiexu1992
Copy link
Contributor

@jackiexu1992 jackiexu1992 commented Sep 14, 2023 •
edited by pytorch-bot bot
Loading

Summary: Log graph with Everpaste for debug and find more patterns to fuse

Test Plan: to add logs

Differential Revision: D49284640

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109314

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 800ef8f with merge base aed9bee (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49284640

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

jackiexu1992 added a commit to jackiexu1992/pytorch that referenced this pull request Sep 14, 2023
@jackiexu1992 @facebook-github-bot
[inductor][Optimus]Improve logging for group batch fusion (pytorch#10…
02e4bbb 
…9314)

Summary:

Log graph with Everpaste for debug and find more patterns to fuse

Test Plan: to add logs

Reviewed By: yanboliang

Differential Revision: D49284640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49284640

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49284640

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49284640

@jackiexu1992 @facebook-github-bot
[inductor][Optimus]Improve logging for group batch fusion (pytorch#10…
800ef8f 
…9314)

Summary:

Log graph with Everpaste for debug and find more patterns to fuse

Test Plan:
```
[2023-09-14 22:26:53,449] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] Apply fusion BatchLinearFusion. Print graph: https://www.internalfb.com/intern/everpaste/?color=0&handle=GCfrCBNt9SP9x4MDAHouROPiHlkxbr0LAAAz
[2023-09-14 22:26:54,817] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] Apply fusion BatchLinearLHSFusion. Print graph: https://www.internalfb.com/intern/everpaste/?color=0&handle=GP8UmhbRVpKo6DECAGZjVkwwnj0pbr0LAAAz
[2023-09-14 22:26:54,897] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] BatchLayernormFusion: key = ('batch_layernorm', 'torch.Size([2048, 96])', 'torch.Size([96])', 'torch.Size([96])', '(96,)', '1e-05'); subset size = 60
[2023-09-14 22:26:54,982] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] BatchLayernormFusion: key = ('batch_layernorm', 'torch.Size([2048, 48])', 'torch.Size([48])', 'torch.Size([48])', '(48,)', '1e-05'); subset size = 10
[2023-09-14 22:26:56,271] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] Apply fusion BatchLayernormFusion. Print graph: https://www.internalfb.com/intern/everpaste/?color=0&handle=GGFLmBbZbscX2uoCAPOeQh04RQwrbr0LAAAz
[2023-09-14 22:26:57,969] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] Apply fusion BatchTanhFusion. Print graph: https://www.internalfb.com/intern/everpaste/?color=0&handle=GEiljRbUagk50vkAAESJWARlM1Unbr0LAAAz
[2023-09-14 22:26:58,194] [3/0] torch._inductor.fx_passes.split_cat: [WARNING] example value absent for node: cat_45
[2023-09-14 22:27:35,905] [3/0] torch._inductor.compile_fx: [INFO] Step 3: torchinductor compiling FORWARDS graph 0
[2023-09-14 22:27:41,707] [3/0] torch._inductor.fx_passes.group_batch_fusion: [INFO] Before group_batch fusion in post grads pass. Print graph: https://www.internalfb.com/intern/everpaste/?color=0&handle=GMa2RRYT4H7Vt78AAP4Th57LhxMZbr0LAAAz
```

Reviewed By: yanboliang

Differential Revision: D49284640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49284640

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@jackiexu1992 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 15, 2023
@pytorchmergebot
Revert "[inductor][Optimus]Improve logging for group batch fusion (#1…
7af792a 
…09314)"

This reverts commit afad0d0.

Reverted #109314 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#109314 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackiexu1992 @facebook-github-bot @pytorchmergebot @yanboliang