Add symbolic singleton int #110370

soulitzer · 2023-10-02T01:18:40Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2023-10-02T01:18:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110370

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit b566a52 with merge base f878633 ():

NEW FAILURE - The following job has failed:

pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 2, linux.2xlarge) (gh)

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 2, linux.2xlarge) (gh)

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

trunk / linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

test/test_sympy_utils.py

ezyang · 2023-10-03T14:21:00Z

test/test_sympy_utils.py

+        # ge
+        self.assertTrue(is_ge(j1, sympy.Integer(1)))
+        with self.assertRaisesRegex(ValueError, "indeterminate"):
+            is_ge(j1, sympy.Integer(3))


This being indeterminate is kind of interesting, it's possible we should just return False here. Well this is fine for now.

Yeah this is a tricky one because sympy only allows overriding of Ge. The other relations (Lt, Gt, Le) are, by consequence, all derived from Ge e.g., Lt(a, b) := !Ge(a, b). This would mean if we define the "indeterminate" j1 >= 3, the also "indeterminate" j0 < 3 will be evaluated to be True!

yeah fine for now

torch/utils/_sympy/singleton_int.py

ezyang

idk if all the rules are right but whatever, we can fix them as we go

[ghstack-poisoned]

Separating this out so we can check perf more easily Pull Request resolved: #110371 Approved by: https://github.com/ezyang ghstack dependencies: #110044, #110369, #110370

Pull Request resolved: #110372 Approved by: https://github.com/ezyang ghstack dependencies: #110044, #110369, #110370, #110371

PaliC · 2023-10-05T23:45:36Z

@pytorchbot revert -m "bottom diff is causing a plethora of internal failures" -c ghfirst

pytorchmergebot · 2023-10-05T23:47:03Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-10-05T23:47:14Z

@soulitzer your PR has been successfully reverted.

This reverts commit a7145cb. Reverted #110370 on behalf of https://github.com/PaliC due to bottom diff is causing a plethora of internal failures ([comment](#110370 (comment)))

reland of #110370 [ghstack-poisoned]

reland of #110370 Pull Request resolved: #110674 Approved by: https://github.com/ezyang ghstack dependencies: #110673

Add symbolic singleton int

e6c9634

[ghstack-poisoned]

soulitzer requested a review from ezyang October 2, 2023 01:43

soulitzer added 2 commits October 2, 2023 12:03

Update on "Add symbolic singleton int"

40ef214

[ghstack-poisoned]

Update on "Add symbolic singleton int"

5e12649

[ghstack-poisoned]

soulitzer added the topic: not user facing topic category label Oct 2, 2023

ezyang reviewed Oct 3, 2023

View reviewed changes

test/test_sympy_utils.py Outdated Show resolved Hide resolved

ezyang reviewed Oct 3, 2023

View reviewed changes

test/test_sympy_utils.py Outdated Show resolved Hide resolved

ezyang reviewed Oct 3, 2023

View reviewed changes

torch/utils/_sympy/singleton_int.py Outdated Show resolved Hide resolved

ezyang approved these changes Oct 3, 2023

View reviewed changes

soulitzer added 3 commits October 3, 2023 12:08

Update on "Add symbolic singleton int"

ddcb402

[ghstack-poisoned]

Update on "Add symbolic singleton int"

09f3f48

[ghstack-poisoned]

Update on "Add symbolic singleton int"

f52ff2e

[ghstack-poisoned]

This was referenced Oct 4, 2023

[ignore] Copy paste Brian's changes for testing #110528

Closed

Compile NestedTensor with AOTAutograd #110529

Closed

Update on "Add symbolic singleton int"

b566a52

[ghstack-poisoned]

soulitzer added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2023

pytorchmergebot added the Merged label Oct 4, 2023

pytorchmergebot closed this in a7145cb Oct 4, 2023

pytorchmergebot pushed a commit that referenced this pull request Oct 4, 2023

Symintify guards.cpp (#110371)

e1cfcdf

Separating this out so we can check perf more easily Pull Request resolved: #110371 Approved by: https://github.com/ezyang ghstack dependencies: #110044, #110369, #110370

pytorchmergebot pushed a commit that referenced this pull request Oct 4, 2023

Use is_symbolic instead of testing isinstance in some place (#110372)

8672d64

Pull Request resolved: #110372 Approved by: https://github.com/ezyang ghstack dependencies: #110044, #110369, #110370, #110371

pytorchmergebot added the Reverted label Oct 5, 2023

soulitzer reopened this Oct 6, 2023

soulitzer closed this Oct 6, 2023

soulitzer mentioned this pull request Oct 6, 2023

[reland] Add symbolic singleton int #110674

Closed

soulitzer added a commit that referenced this pull request Oct 6, 2023

Update base for Update on "[reland] Add symbolic singleton int"

8feb9fe

reland of #110370 [ghstack-poisoned]

soulitzer added a commit that referenced this pull request Oct 6, 2023

Update on "[reland] Add symbolic singleton int"

28aab76

reland of #110370 [ghstack-poisoned]

facebook-github-bot deleted the gh/soulitzer/237/head branch October 9, 2023 14:24

soulitzer added a commit that referenced this pull request Oct 10, 2023

Update base for Update on "[reland] Add symbolic singleton int"

2b0fe7e

reland of #110370 [ghstack-poisoned]

soulitzer added a commit that referenced this pull request Oct 10, 2023

Update on "[reland] Add symbolic singleton int"

2ff805d

reland of #110370 [ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Oct 10, 2023

[reland] Add symbolic singleton int (#110674)

3842b17

reland of #110370 Pull Request resolved: #110674 Approved by: https://github.com/ezyang ghstack dependencies: #110673

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add symbolic singleton int #110370

Add symbolic singleton int #110370

Uh oh!

soulitzer commented Oct 2, 2023 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 2, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ezyang Oct 3, 2023

Uh oh!

soulitzer Oct 3, 2023 •

edited

Loading

Uh oh!

ezyang Oct 3, 2023

Uh oh!

Uh oh!

ezyang left a comment

Uh oh!

PaliC commented Oct 5, 2023

Uh oh!

pytorchmergebot commented Oct 5, 2023

Uh oh!

pytorchmergebot commented Oct 5, 2023

Uh oh!

Uh oh!

Add symbolic singleton int #110370

Add symbolic singleton int #110370

Uh oh!

Conversation

soulitzer commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110370

❌ 1 New Failure, 2 Unrelated Failures

Uh oh!

Uh oh!

Uh oh!

ezyang Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

soulitzer Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ezyang Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

PaliC commented Oct 5, 2023

Uh oh!

pytorchmergebot commented Oct 5, 2023

Uh oh!

pytorchmergebot commented Oct 5, 2023

Uh oh!

Uh oh!

soulitzer commented Oct 2, 2023 •

edited

Loading

pytorch-bot bot commented Oct 2, 2023 •

edited

Loading

soulitzer Oct 3, 2023 •

edited

Loading