remove replaced symbols from range_constraints #110644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D49969620](https://our.internmc.facebook.com/intern/diff/D49969620/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110644
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f8ff062 with merge base 11b3210 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
While the `range_constraints` that is initially derived by processing of constraints only contains symbols that appear in the graph module, eventually the `range_constraints` that are in the exported program seem to contain more symbols than those that appear in the graph module. Clearly this is a regression, because the example in the docs does not show the extra symbols, but running the example does. The problem seems to arise when we are running `_transform` passes, where we regenerate the `range_constraints` from the `shape_env`. However, as a rule, symbols that have `replacements` are actually replaced (by other expressions, including constants or other symbols), so they should never appear in the graph module. Thus we can filter such symbols out from `range_constraints` as well. Differential Revision: [D49969620](https://our.internmc.facebook.com/intern/diff/D49969620/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Oct 5, 2023
Pull Request resolved: #110644 ghstack-source-id: 203102701 @exported-using-ghexport Differential Revision: [D49969620](https://our.internmc.facebook.com/intern/diff/D49969620/)
While the `range_constraints` that is initially derived by processing of constraints only contains symbols that appear in the graph module, eventually the `range_constraints` that are in the exported program seem to contain more symbols than those that appear in the graph module. Clearly this is a regression, because the example of "Expressing Dynamism" in our public docs (https://pytorch.org/docs/stable/export.html#expressing-dynamism) does not show the extra symbols in `range_constraints`, but running the example does. The problem seems to arise when we are running `_transform` passes, where we regenerate the `range_constraints` from the `shape_env`. However, as a rule, symbols that have `replacements` are actually replaced (by other expressions, including constants or other symbols), so they should never appear in the graph module. Thus we can filter such symbols out from `range_constraints` as well. Differential Revision: [D49969620](https://our.internmc.facebook.com/intern/diff/D49969620/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Oct 6, 2023
Pull Request resolved: #110644 ghstack-source-id: 203199808 @exported-using-ghexport Differential Revision: [D49969620](https://our.internmc.facebook.com/intern/diff/D49969620/)
zhxchen17
approved these changes
Oct 6, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
While the
range_constraintsthat is initially derived by processing of constraints only contains symbols that appear in the graph module, eventually therange_constraintsthat are in the exported program seem to contain more symbols than those that appear in the graph module. Clearly this is a regression, because the example of "Expressing Dynamism" in our public docs (https://pytorch.org/docs/stable/export.html#expressing-dynamism) does not show the extra symbols inrange_constraints, but running the example does.The problem seems to arise when we are running
_transformpasses, where we regenerate therange_constraintsfrom theshape_env. However, as a rule, symbols that havereplacementsare actually replaced (by other expressions, including constants or other symbols), so they should never appear in the graph module. Thus we can filter such symbols out fromrange_constraintsas well.Differential Revision: D49969620