Skip to content

Update arg{min,max} tests and docs #110845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update arg{min,max} tests and docs #110845

wants to merge 3 commits into from

Conversation

int3
Copy link
Contributor

@int3 int3 commented Oct 9, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

The argmin docs had been updated in
#78791 but left a minor typo.

argmax had a similar issue but was not noticed.

@int3
[WIP] improve reduction tests
401b3ef 
[ghstack-poisoned]
@int3 int3 mentioned this pull request Oct 9, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110845

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit baf89d3 with merge base de1ca4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

int3 added a commit that referenced this pull request Oct 9, 2023
@int3
[WIP] improve reduction tests
dbaf3eb 
ghstack-source-id: 32d4af5
Pull Request resolved: #110845
@int3 int3 changed the title [WIP] improve reduction tests Update arg{min,max} tests and docs Oct 11, 2023
@int3
Update on "Update arg{min,max} tests and docs"
baf89d3 
The `argmin` docs had been updated in
#78791 but left a minor typo.

`argmax` had a similar issue but was not noticed.

[ghstack-poisoned]
int3 added a commit that referenced this pull request Oct 11, 2023
@int3
Update arg{min,max} tests and docs
c88e71a 
The `argmin` docs had been updated in
#78791 but left a minor typo.

`argmax` had a similar issue but was not noticed.

ghstack-source-id: e7868b2
Pull Request resolved: #110845
@int3 int3 requested a review from eellison October 11, 2023 21:11
@int3 int3 added the topic: not user facing topic category label Oct 11, 2023
@int3 int3 marked this pull request as ready for review October 12, 2023 17:38
@int3 int3 requested review from mruberry and ngimel as code owners October 12, 2023 17:38
@int3
Copy link
Contributor Author

int3 commented Oct 13, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/int3/40/head branch October 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@int3 @pytorchmergebot @eellison