[TP] Add deprecation warnings in the documentations for Pairwise parallel, sequence parallel and other prepare input/output functions #111176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111176
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f3b9d7 with merge base 35750bf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fduwjj
changed the title
fduwjj
added
ciflow/trunk
wanchaol
reviewed
Oct 13, 2023
… parallel and other prepare input/output functions" As part of TP UX improvements, we want to keep our API simple (not easy) so that users get the flexibility to do what they want and avoid a too generic API which tries to solve everything and get things too complicated. We are updating the doc accordingly. [ghstack-poisoned]
… parallel and other prepare input/output functions" As part of TP UX improvements, we want to keep our API simple (not easy) so that users get the flexibility to do what they want and avoid a too generic API which tries to solve everything and get things too complicated. We are updating the doc accordingly. [ghstack-poisoned]
… parallel and other prepare input/output functions" As part of TP UX improvements, we want to keep our API simple (not easy) so that users get the flexibility to do what they want and avoid a too generic API which tries to solve everything and get things too complicated. We are updating the doc accordingly. [ghstack-poisoned]
|
https://docs-preview.pytorch.org/pytorch/pytorch/111176/distributed.tensor.parallel.html looks like prepare input/outout docs still have issues |
|
@pytorchbot merge |
fduwjj
changed the title
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@fduwjj This is not related to deprecation warning, see here https://docs-preview.pytorch.org/pytorch/pytorch/111176/distributed.tensor.parallel.html#torch.distributed.tensor.parallel.style.PrepareModuleOutput The examples in the doc are not properly formatted |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 15, 2023
We see use cases where embedding sharding is also needed in TP API so we enabled it in the API since DTensor already support colwise embedding sharding. Pull Request resolved: #111177 Approved by: https://github.com/wanchaol ghstack dependencies: #111160, #111166, #111176
yeounoh
pushed a commit
to yeounoh/pytorch
that referenced
this pull request
Oct 16, 2023
…llel, sequence parallel and other prepare input/output functions (pytorch#111176) As part of TP UX improvements, we want to keep our API simple (not easy) so that users get the flexibility to do what they want and avoid a too generic API which tries to solve everything and get things too complicated. We are updating the doc accordingly. Pull Request resolved: pytorch#111176 Approved by: https://github.com/wanchaol ghstack dependencies: pytorch#111160, pytorch#111166
yeounoh
pushed a commit
to yeounoh/pytorch
that referenced
this pull request
Oct 16, 2023
We see use cases where embedding sharding is also needed in TP API so we enabled it in the API since DTensor already support colwise embedding sharding. Pull Request resolved: pytorch#111177 Approved by: https://github.com/wanchaol ghstack dependencies: pytorch#111160, pytorch#111166, pytorch#111176
yeounoh
pushed a commit
to yeounoh/pytorch
that referenced
this pull request
Oct 16, 2023
Pull Request resolved: pytorch#111346 Approved by: https://github.com/wanchaol ghstack dependencies: pytorch#111160, pytorch#111166, pytorch#111176, pytorch#111177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As part of TP UX improvements, we want to keep our API simple (not easy) so that users get the flexibility to do what they want and avoid a too generic API which tries to solve everything and get things too complicated. We are updating the doc accordingly.