Skip to content

[AOT Refactor] alias runtime wrappers #114562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[AOT Refactor] alias runtime wrappers #114562

wants to merge 8 commits into from

Conversation

jon-chuang
Copy link
Collaborator

@jon-chuang jon-chuang commented Nov 26, 2023 •
edited
Loading

This was referenced Nov 26, 2023
Closed
Closed
@jon-chuang jon-chuang mentioned this pull request Nov 26, 2023
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114562

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 1833861 with merge base ffa974b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 26, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 26, 2023
Closed
Closed
jon-chuang added a commit that referenced this pull request Nov 26, 2023
@jon-chuang
[AOT Refactor] alias runtime wrappers
482d88c 
ghstack-source-id: 5f2ff86
Pull Request resolved: #114562
This was referenced Nov 26, 2023
Closed
Closed
This was referenced Nov 27, 2023
Closed
Closed
@bdhirsh
Copy link
Contributor

bdhirsh commented Nov 28, 2023

I know the # of LOC is pretty long, but I would prefer to put these in the runtime_wrappers.py file instead of having a separate alias_runtime_wrappers.py file. That way they're all in one place, and you can easily see what all the various runtime transformations are.

@jon-chuang
Copy link
Collaborator Author

Ok, I'll keep the stacked PR structure just move it to that file

@jon-chuang jon-chuang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2023
@jon-chuang
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 4 jobs have failed, first few of them are: trunk, linux-binary-libtorch-pre-cxx11, inductor-periodic, inductor

Details for Dev Infra team Raised by workflow job

@jon-chuang
Copy link
Collaborator Author

@pytorchbot merge -f "flakey CI and stacked PRs pass"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 30, 2023
@jon-chuang @pytorchmergebot
[AOT Refactor] dispatch compile graph (#114563)
741414b 
---

Part _ of #114548
Pull Request resolved: #114563
Approved by: https://github.com/bdhirsh
ghstack dependencies: #114550, #114551, #114552, #114553, #114554, #114555, #114556, #114557, #114558, #114559, #114561, #114562
pytorchmergebot pushed a commit that referenced this pull request Nov 30, 2023
@jon-chuang @pytorchmergebot
[AOT Refactor] jit compile runtime wrappers (#114564)
80ae00d 
---

Part _ of #114548

Total reduction in lines: 5200 lines -> 1100 lines

Pull Request resolved: #114564
Approved by: https://github.com/bdhirsh
ghstack dependencies: #114550, #114551, #114552, #114553, #114554, #114555, #114556, #114557, #114558, #114559, #114561, #114562, #114563
@facebook-github-bot facebook-github-bot deleted the gh/jon-chuang/54/head branch December 3, 2023 15:27
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@jon-chuang @dmenig
[AOT Refactor] alias runtime wrappers (pytorch#114562)
5745716 
---

Part _ of pytorch#114548

Pull Request resolved: pytorch#114562
Approved by: https://github.com/bdhirsh
ghstack dependencies: pytorch#114550, pytorch#114551, pytorch#114552, pytorch#114553, pytorch#114554, pytorch#114555, pytorch#114556, pytorch#114557, pytorch#114558, pytorch#114559, pytorch#114561
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@jon-chuang @dmenig
[AOT Refactor] dispatch compile graph (pytorch#114563)
d717643 
---

Part _ of pytorch#114548
Pull Request resolved: pytorch#114563
Approved by: https://github.com/bdhirsh
ghstack dependencies: pytorch#114550, pytorch#114551, pytorch#114552, pytorch#114553, pytorch#114554, pytorch#114555, pytorch#114556, pytorch#114557, pytorch#114558, pytorch#114559, pytorch#114561, pytorch#114562
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@jon-chuang @dmenig
[AOT Refactor] jit compile runtime wrappers (pytorch#114564)
7e5c1b6 
---

Part _ of pytorch#114548

Total reduction in lines: 5200 lines -> 1100 lines

Pull Request resolved: pytorch#114564
Approved by: https://github.com/bdhirsh
ghstack dependencies: pytorch#114550, pytorch#114551, pytorch#114552, pytorch#114553, pytorch#114554, pytorch#114555, pytorch#114556, pytorch#114557, pytorch#114558, pytorch#114559, pytorch#114561, pytorch#114562, pytorch#114563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: AO frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jon-chuang @bdhirsh @pytorchmergebot @pytorchbot