Skip to content

[export] Fix run_decomps to work with fake mode #114714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export] Fix run_decomps to work with fake mode #114714

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

Fixes #114711

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114714

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e8b83d with merge base 765d459 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi angelayi requested a review from ydwu4 November 28, 2023 23:00
@angelayi angelayi force-pushed the angelayi/fake_decomp branch from 5f6c42f to 9e8b83d Compare November 28, 2023 23:06
@angelayi angelayi added the topic: not user facing topic category label Nov 28, 2023
ydwu4
ydwu4 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ydwu4 ydwu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the angelayi/fake_decomp branch February 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@ydwu4 ydwu4 ydwu4 approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FakeTensorMode not preserved within torch.export.ExportedProgram.run_decompositions
4 participants
@angelayi @pytorchmergebot @zhxchen17 @ydwu4