-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Add aten/src/ATen/native/quantized/cpu/ path to CPU quantization merge rule #116145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116145
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 559074f with merge base f88c9af ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Why do we need 3 different rules? For x86 CPU quantization
as well as for CPU frontend
reviewers are the same, should those two rules be folded together?
This is because the rules are organized by the modules and the reviewers happen to be the same. |
@pytorchmergebot merge -f "All required jobs are passing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…e rule (pytorch#116145) Observing following PR: pytorch#115329 Comment from author: pytorch#115329 (comment) pytorchbot merge failed. Reason is this logic, we expect all files in PR to match one merge rule: https://github.com/pytorch/pytorch/blob/110339a310e5c6bc0aef04b6b1d848976d10013e/.github/scripts/trymerge.py#L1310-L1324 This should mitigate the issue, followup will post a PR to refactor this code to allow cross rule matching of approvers Pull Request resolved: pytorch#116145 Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/malfet
Observing following PR: #115329
Comment from author: #115329 (comment)
pytorchbot merge failed.
Reason is this logic, we expect all files in PR to match one merge rule:
pytorch/.github/scripts/trymerge.py
Lines 1310 to 1324 in 110339a
This should mitigate the issue, followup will post a PR to refactor this code to allow cross rule matching of approvers