Skip to content

Update logging.cpp for explicit chrono import #119469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update logging.cpp for explicit chrono import #119469

wants to merge 1 commit into from

Conversation

qlzh727
Copy link
Contributor

@qlzh727 qlzh727 commented Feb 8, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119469

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 91a01f5 with merge base 2b9cba8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Feb 8, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 8, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: qlzh727 / name: Qianli Scott Zhu (91a01f5)

@cpuhrsch cpuhrsch added oncall: jit Add this issue/PR to JIT oncall triage queue and removed topic: build labels Feb 8, 2024
davidberard98
davidberard98 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests passing :)

@davidberard98
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 8, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@davidberard98 davidberard98 added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2024
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@qlzh727 @clee2000
Update logging.cpp for explicit chrono import (#119469)
7477b8f 
Pull Request resolved: #119469
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qlzh727 @davidberard98 @pytorchmergebot @cpuhrsch @pytorchbot