-
Notifications
You must be signed in to change notification settings - Fork 24.5k
[dynamo] Use EQUALS_MATCH guard for mod.training #120147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120147
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (9 Unrelated Failures)As of commit 1d935e6 with merge base 7b1f5c8 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix tests
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot merge |
The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: pytorch#120147 Approved by: https://github.com/jansel ghstack dependencies: pytorch#120132, pytorch#120140, pytorch#120145
@pytorchbot --help |
PyTorchBot Help
Merge
Revert
Rebase
Label
Dr CI
cherry-pick
Closeusage: @pytorchbot close Close a PR [Can be used on issues] |
@pytorchbot revert -m "memory leak, see #112090" -c nosignal |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit b642a18. Reverted #120147 on behalf of https://github.com/williamwen42 due to memory leak, see #112090 ([comment](#120147 (comment)))
@anijain2305 your PR has been successfully reverted. |
This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…ry leaks" This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…ry leaks" This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
…ry leaks" This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
This issue was raised by a regression of #112090 caused by #120147. Make the memory leak test stronger by using weakref to check for model deletion instead of measuring CUDA memory allocation. Pull Request resolved: #120459 Approved by: https://github.com/jansel
Closing in favor of #120578 |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng