Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_aot_inductor to test_inductor #123340

Closed
wants to merge 1 commit into from

Conversation

jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Apr 4, 2024

AOTI changes have been breaking for ROCm on trunk because we do not have testing of AOTI in inductor/pull/trunk workflow for ROCm. This PR adds test_aot_inductor to inductor workflow to catch such issues.

More context here: #123164 (comment)

Runtime increase for inductor workflow:
CUDA:
PR corresponding to base commit used for this PR: 100 mins
This PR: 183 mins

ROCM:
PR corresponding to base commit used for this PR: 105 mins
This PR: 148 mins

Copy link

pytorch-bot bot commented Apr 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123340

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 8c8db23 with merge base 8b83327 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jithunnair-amd jithunnair-amd changed the title Add aot_test_inductor to test_inductor Add test_aot_inductor to test_inductor Apr 4, 2024
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_aot_inductor_testing onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_aot_inductor_testing && git pull --rebase)

@huydhn huydhn added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 5, 2024
@jithunnair-amd jithunnair-amd added the rocm This tag is for PRs from ROCm team label Apr 9, 2024
@atalman
Copy link
Contributor

atalman commented Apr 9, 2024

cc @desertfire could you please take a look ?

@jithunnair-amd jithunnair-amd marked this pull request as ready for review April 9, 2024 21:17
@jithunnair-amd jithunnair-amd requested a review from a team as a code owner April 9, 2024 21:17
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot merge -f "Changes impact inductor workflow only, for which tests succeeded"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
AOTI changes have been breaking for ROCm on trunk because we do not have testing of AOTI in inductor/pull/trunk workflow for ROCm. This PR adds `test_aot_inductor` to inductor workflow to catch such issues.

More context here: pytorch#123164 (comment)

Runtime increase for inductor workflow:
CUDA:
PR corresponding to base commit used for this PR: [100 mins](https://github.com/pytorch/pytorch/actions/runs/8545475047/job/23415210028?pr=123290)
This PR: [183 mins](https://github.com/pytorch/pytorch/actions/runs/8562003098/job/23465530389?pr=123340)

ROCM:
PR corresponding to base commit used for this PR: [105 mins](https://github.com/pytorch/pytorch/actions/runs/8545475047/job/23416422145?pr=123290)
This PR: [148 mins](https://github.com/pytorch/pytorch/actions/runs/8562003098/job/23466516866?pr=123340)
Pull Request resolved: pytorch#123340
Approved by: https://github.com/atalman, https://github.com/desertfire
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
AOTI changes have been breaking for ROCm on trunk because we do not have testing of AOTI in inductor/pull/trunk workflow for ROCm. This PR adds `test_aot_inductor` to inductor workflow to catch such issues.

More context here: #123164 (comment)

Runtime increase for inductor workflow:
CUDA:
PR corresponding to base commit used for this PR: [100 mins](https://github.com/pytorch/pytorch/actions/runs/8545475047/job/23415210028?pr=123290)
This PR: [183 mins](https://github.com/pytorch/pytorch/actions/runs/8562003098/job/23465530389?pr=123340)

ROCM:
PR corresponding to base commit used for this PR: [105 mins](https://github.com/pytorch/pytorch/actions/runs/8545475047/job/23416422145?pr=123290)
This PR: [148 mins](https://github.com/pytorch/pytorch/actions/runs/8562003098/job/23466516866?pr=123340)
Pull Request resolved: #123340
Approved by: https://github.com/atalman, https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/rocm ciflow/trunk Trigger trunk jobs on your pull request Merged open source rocm This tag is for PRs from ROCm team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants