[inductor] Refactor runtime files into torch._inductor.runtime (part 1) #124552

jansel · 2024-04-20T18:59:53Z

Stack from ghstack (oldest at bottom):

I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-04-20T18:59:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124552

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 121328c with merge base 29cc293 ():

NEW FAILURE - The following job has failed:

pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

…2) (#124553) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124553 Approved by: https://github.com/yanboliang ghstack dependencies: #124552

…3) (#124557) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124557 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553

…4) (#124559) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124559 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557

…5) (#124560) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124560 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559

This makes the check per-kernel (if 3D tiling is used), rather than global config. Pull Request resolved: #124569 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559, #124560

This removes usage of torch._inductor.config from `torch._inductor.runtime`. Fixing two issues: 1) If configs change we should really use the compile time ones 2) In compile workers, we want to use the parent process config Pull Request resolved: #124561 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559, #124560, #124569

jeanschmidt · 2024-04-22T18:25:59Z

@pytorchbot revert -m "There are internal breakages, already discussed with author and he'll FF" -c nosignal

…1) (pytorch#124552) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124552 Approved by: https://github.com/yanboliang

…2) (pytorch#124553) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124553 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552

…3) (pytorch#124557) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124557 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552, pytorch#124553

…4) (pytorch#124559) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124559 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552, pytorch#124553, pytorch#124557

…5) (#124560) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124560 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559

This makes the check per-kernel (if 3D tiling is used), rather than global config. Pull Request resolved: #124569 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559, #124560

This removes usage of torch._inductor.config from `torch._inductor.runtime`. Fixing two issues: 1) If configs change we should really use the compile time ones 2) In compile workers, we want to use the parent process config Pull Request resolved: pytorch#124561 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552, pytorch#124553, pytorch#124557, pytorch#124559, pytorch#124560, pytorch#124569

This reverts commit 317c0af. Reverted pytorch#124569 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](pytorch#124552 (comment)))

…e (part 5) (pytorch#124560)" This reverts commit 3ac30bc. Reverted pytorch#124560 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](pytorch#124552 (comment)))

…e (part 4) (pytorch#124559)" This reverts commit 9ea2a09. Reverted pytorch#124559 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](pytorch#124552 (comment)))

…e (part 3) (pytorch#124557)" This reverts commit fcf28b0. Reverted pytorch#124557 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](pytorch#124552 (comment)))

…e (part 2) (pytorch#124553)" This reverts commit f4d47f5. Reverted pytorch#124553 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](pytorch#124552 (comment)))

…e (part 1) (#124552)" This reverts commit a7035cc. Reverted #124552 on behalf of https://github.com/jeanschmidt due to There are internal breakages, already discussed with author and he'll FF ([comment](#124552 (comment)))

…1) (pytorch#124552) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124552 Approved by: https://github.com/yanboliang

…2) (#124553) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124553 Approved by: https://github.com/yanboliang ghstack dependencies: #124552

…3) (#124557) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124557 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553

…4) (pytorch#124559) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: pytorch#124559 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552, pytorch#124553, pytorch#124557

…5) (#124560) I am planning to make the compile_worker process not import torch so it can start up much faster. This stack is prep for that. Pull Request resolved: #124560 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559

This makes the check per-kernel (if 3D tiling is used), rather than global config. Pull Request resolved: #124569 Approved by: https://github.com/yanboliang ghstack dependencies: #124552, #124553, #124557, #124559, #124560

This removes usage of torch._inductor.config from `torch._inductor.runtime`. Fixing two issues: 1) If configs change we should really use the compile time ones 2) In compile workers, we want to use the parent process config Pull Request resolved: pytorch#124561 Approved by: https://github.com/yanboliang ghstack dependencies: pytorch#124552, pytorch#124553, pytorch#124557, pytorch#124559, pytorch#124560, pytorch#124569

Update

00c6e94

[ghstack-poisoned]

jansel requested a review from albanD as a code owner April 20, 2024 18:59

pytorch-bot bot added ciflow/inductor module: inductor labels Apr 20, 2024

This was referenced Apr 20, 2024

[inductor] Refactor runtime files into torch._inductor.runtime (part 2) #124553

Closed

[inductor] Add ProcessPool-in-subproc worker_start_method #122941

Closed

jansel added 2 commits April 20, 2024 12:06

Update

1bfbc83

[ghstack-poisoned]

Update

1ffb6c3

[ghstack-poisoned]

jansel mentioned this pull request Apr 20, 2024

[inductor] Refactor runtime files into torch._inductor.runtime (part 3) #124557

Closed

Update

9d8a09d

[ghstack-poisoned]

This was referenced Apr 20, 2024

[inductor] Refactor runtime files into torch._inductor.runtime (part 4) #124559

Closed

[inductor] Refactor runtime files into torch._inductor.runtime (part 5) #124560

Closed

[inductor] Use compile time config values in runtime #124561

Closed

jansel added the topic: not user facing topic category label Apr 21, 2024

jansel added 2 commits April 20, 2024 21:11

Update

b33c02a

[ghstack-poisoned]

Update

121328c

[ghstack-poisoned]

jansel mentioned this pull request Apr 21, 2024

[inductor] Remove config check for 3D tiling #124569

Closed

jansel requested a review from yanboliang April 21, 2024 18:04

yanboliang approved these changes Apr 22, 2024

View reviewed changes

pytorchmergebot closed this in a7035cc Apr 22, 2024

pytorchmergebot added the Merged label Apr 22, 2024

github-actions bot deleted the gh/jansel/321/head branch June 2, 2024 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[inductor] Refactor runtime files into torch._inductor.runtime (part 1) #124552

[inductor] Refactor runtime files into torch._inductor.runtime (part 1) #124552

Uh oh!

jansel commented Apr 20, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 20, 2024 •

edited

Loading

Uh oh!

jeanschmidt commented Apr 22, 2024

Uh oh!

Uh oh!

[inductor] Refactor runtime files into torch._inductor.runtime (part 1) #124552

[inductor] Refactor runtime files into torch._inductor.runtime (part 1) #124552

Uh oh!

Conversation

jansel commented Apr 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124552

❌ 1 New Failure

Uh oh!

jeanschmidt commented Apr 22, 2024

Uh oh!

Uh oh!

jansel commented Apr 20, 2024 •

edited

Loading

pytorch-bot bot commented Apr 20, 2024 •

edited

Loading