[Pipelining] Add debug logs for batch p2p ops #126539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
pytorch-bot
bot
added
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126539
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 60a400d with merge base failed to retrieve merge base, please contact dev infra: NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: af8a7f9239c14201b101dd11f717fd0ded684916 Pull Request resolved: #126539
wconstab
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 1428927a0ef398eb96a90f8cb9231e544c533caf Pull Request resolved: #126539
wconstab
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: ba1bfd016e856f019094d77bd77667a19d9d883c Pull Request resolved: #126539
kwen2501
approved these changes
May 17, 2024
wconstab
added a commit
that referenced
this pull request
May 17, 2024
Also include 'dtype' in the existing debug print helper. ghstack-source-id: fe0ad33e3bea1694a8a9fb91c4525a3f11b60cdf Pull Request resolved: #126539
|
@pytorchbot merge -f "intentional BC change for newly added (as yet unreleased) API" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 21, 2024
Pull Request resolved: #126582 Approved by: https://github.com/kwen2501 ghstack dependencies: #126539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
logs from torchtitan:
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @yf225 @chauhang @d4l3k