[torchscript] Handle prim::device and prim::dtype #127466
Conversation
BoyuanFeng
commented
May 29, 2024
BoyuanFeng
commented
- Support prim::device and prim::dtype during torchscript migration to export
- Add unit tests
BoyuanFeng
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127466
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 595f409 with merge base 39cf2f8 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| elif output_name in self.constant_map: | ||
| args.append(self.constant_map[output_name]) | ||
| self.output_specs.append( | ||
| OutputSpec( |
There was a problem hiding this comment.
Does PT2 IR allow graph returning constant?
There was a problem hiding this comment.
I don't think we do right now Sorry I misread the serializer -- we do allow returning constants.
|
@pytorchbot merge -f "skip unrelated flaky test" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
- Support prim::device and prim::dtype during torchscript migration to export - Add unit tests Pull Request resolved: pytorch#127466 Approved by: https://github.com/SherlockNoMad
