Make sure #126704 is BC for torch.save-ed nn.Module

[mikaylagawarecki]

Stack from ghstack (oldest at bottom):

• -> Make sure #126704 is BC for torch.save-ed nn.Module #128344
• Make nn.Module state_dict load_state_dict pre-hook and state_dict post hook public #126704
• [easy] Move state_dict hooks tests to test_module_hooks and decorate tests that call load_state_dict with swap #126906

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128344

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 12 Pending, 2 Unrelated Failures

As of commit 413d84c with merge base b66e3f0 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, linux.2xlarge) (gh) (similar failure)
  Process completed with exit code 1.
• trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral) (gh) (matched win rule in flaky-rules.json)
  The process cannot access the file 'C:\actions-runner\_work\_actions\pytorch\pytorch\main\aten\src\ATen\native\quantized\cpu\qnnpack\cmake' because it is being used by another process.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[albanD]

Thanks for the quick PR!

[mikaylagawarecki]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x d80ae143c893cf56bf33285782277a39f6432fbb returned non-zero exit code 1

Auto-merging torch/nn/modules/module.py
CONFLICT (content): Merge conflict in torch/nn/modules/module.py
error: could not apply d80ae143c89... Make sure #126704 is BC for torch.save-ed `nn.Module`
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

[mikaylagawarecki]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

@mikaylagawarecki your PR has been successfully reverted.

[mikaylagawarecki]

No longer needed