-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Don't install remaining caffe2 python files #129067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install remaining caffe2 python files #129067
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129067
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2a6e8ae with merge base 6e43897 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Without this change "python setup.py develop --user" fails when running from non-root user. |
fdcdd72
to
97ceba7
Compare
@AlekseiNikiforovIBM It is used to install caffe2 py files. Now there are only three such files
I suspect that they shouldn't be installed and that the entire section of CMake code should be deleted as well. |
Sounds good to me. |
@AlekseiNikiforovIBM Would you mind change this PR to remove them? |
5bf6ebf
to
436add0
Compare
With this change it should work on your host. |
@AlekseiNikiforovIBM Please remove caffe2/core/init.py and caffe2/perfkernels/init.py here. |
It is assumed that they are no longer needed. And keeping their installation as is breaks "python setup.py develop --user" workflow when non-root user is used. This change is follow up for 3d61733
436add0
to
2a6e8ae
Compare
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
@malfet Could you please approve this if it is good? |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
It is assumed that they are no longer needed.
And keeping their installation as is breaks
"python setup.py develop --user" workflow
when non-root user is used.
This change is follow up for 3d61733