Skip to content

[ONNX] Add artifacts_dir to torch-onnx-patch in benchmark #130069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ONNX] Add artifacts_dir to torch-onnx-patch in benchmark #130069

wants to merge 1 commit into from

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Jul 3, 2024 •
edited by pytorch-bot bot
Loading

Add artifacts_dir to torch-onnx-patch to save error report for debugging.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

@titaiwangms titaiwangms requested a review from justinchuby July 3, 2024 23:06
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130069

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job

As of commit 07e22fa with merge base a21d436 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby
Copy link
Collaborator

Thanks!

@justinchuby
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@justinchuby justinchuby added the topic: not user facing topic category label Jul 4, 2024
@justinchuby
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jul 6, 2024
@titaiwangms @facebook-github-bot
Add artifacts_dir to torch-onnx-patch in benchmark (#130069)
7cbf487 
Summary:
Add `artifacts_dir` to torch-onnx-patch to save error report for debugging.

X-link: pytorch/pytorch#130069
Approved by: https://github.com/justinchuby

Reviewed By: kit1980

Differential Revision: D59413633

fbshipit-source-id: fbccab831b8b47d877a979825aa90600d008d4f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@titaiwangms @justinchuby @pytorchmergebot @pytorchbot