[pipelining] Refactor test_schedule to fix "-k" #130294
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130294
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit be54f7e with merge base failed to retrieve merge base, please contact dev infra: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
|
|
||
|
|
||
| class TestSchedulePlan(unittest.TestCase): | ||
| class TestSchedulePlan(TestCase): |
There was a problem hiding this comment.
One alternative is to move this test to its own file since this is the only single process test in this file.
There was a problem hiding this comment.
well i added more tests to this file in the later PRs.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "broke lint https://github.com/pytorch/pytorch/actions/runs/9879591538/job/27286156803" -c ignoredsignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@wconstab your PR has been successfully reverted. |
This reverts commit 1352f13. Reverted #130294 on behalf of https://github.com/clee2000 due to broke lint https://github.com/pytorch/pytorch/actions/runs/9879591538/job/27286156803 ([comment](#130294 (comment)))
|
oops. whats the deal though? i did not change the inductor file that has a lint error, so i assumed its an error on trunk and i can ignore it. @clee2000 github shows me this..
correction: it was my fault, i just missed that there was a lint error on this PR since the ghbot showed me lint failures for inductor stuff. |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This is kind of a short-sighted workaround and we should actually come up with a way to fix this in general, but I got annoyed that I can't use -k to filter tests in test_schedule, and realized it's because we jam tests using the new MultiProcContinuousTest fixture together with old-style tests. For now I separate the two types of tests so -k works again. Pull Request resolved: pytorch#130294 Approved by: https://github.com/H-Huang
…)" This reverts commit 1352f13. Reverted pytorch#130294 on behalf of https://github.com/clee2000 due to broke lint https://github.com/pytorch/pytorch/actions/runs/9879591538/job/27286156803 ([comment](pytorch#130294 (comment)))
This is kind of a short-sighted workaround and we should actually come up with a way to fix this in general, but I got annoyed that I can't use -k to filter tests in test_schedule, and realized it's because we jam tests using the new MultiProcContinuousTest fixture together with old-style tests. For now I separate the two types of tests so -k works again. Pull Request resolved: pytorch#130294 Approved by: https://github.com/H-Huang
Stack from ghstack (oldest at bottom):
This is kind of a short-sighted workaround and we should actually come
up with a way to fix this in general, but I got annoyed that I can't use
-k to filter tests in test_schedule, and realized it's because we jam
tests using the new MultiProcContinuousTest fixture together with
old-style tests.
For now I separate the two types of tests so -k works again.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @d4l3k @c-p-i-o @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @chauhang