Skip to content

Updating Types in torch/_dynamo/utils.py #131001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Updating Types in torch/_dynamo/utils.py #131001

wants to merge 4 commits into from

Conversation

adriaorenstein
Copy link
Contributor

@adriaorenstein adriaorenstein commented Jul 17, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131001

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2e8efeb with merge base f8f41dc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@aorenste aorenste marked this pull request as ready for review July 23, 2024 14:28
@aorenste aorenste self-requested a review July 23, 2024 14:28
@aorenste
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 23, 2024
@aorenste aorenste added the topic: not user facing topic category label Jul 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@aorenste
Copy link
Contributor

@pytorchbot merge -f "rocm tests queuing forever"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@PaliC PaliC mentioned this pull request Jul 23, 2024
Closed
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jul 24, 2024
@adriaorenstein @facebook-github-bot
Updating Types in torch/_dynamo/utils.py (#131001)
fe36229 
Summary:
Adds some type annotations to the torch/_dynamo/utils.py file.

X-link: pytorch/pytorch#131001
Approved by: https://github.com/aorenste

Reviewed By: clee2000

Differential Revision: D60151092

fbshipit-source-id: 0ccb475b72b09ef87d67618f3e324faa2f33814a
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@adriaorenstein @xuhancn
Updating Types in torch/_dynamo/utils.py (pytorch#131001)
dc1e3e9 
Adds some type annotations to the torch/_dynamo/utils.py file.

Pull Request resolved: pytorch#131001
Approved by: https://github.com/aorenste
@henrylhtsang henrylhtsang mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aorenste aorenste aorenste approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriaorenstein @aorenste @pytorchmergebot @pytorchbot