Skip to content

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jul 26, 2024

Copy link

pytorch-bot bot commented Jul 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131844

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 49c0f12 with merge base 4a2cf50 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Jul 26, 2024
ghstack-source-id: 65e0e44
Pull Request resolved: #131844
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jul 31, 2024
@drisspg drisspg mentioned this pull request Aug 2, 2024
drisspg added a commit that referenced this pull request Aug 5, 2024
ghstack-source-id: 5fb0e6b
Pull Request resolved: #131844
drisspg added a commit that referenced this pull request Aug 5, 2024
ghstack-source-id: 9f30d2b
Pull Request resolved: #131844
drisspg added a commit that referenced this pull request Aug 5, 2024
ghstack-source-id: 9f30d2b
Pull Request resolved: #131844
@drisspg drisspg requested a review from jbschlosser August 5, 2024 23:16
drisspg added a commit that referenced this pull request Aug 5, 2024
ghstack-source-id: d5a7d2b
Pull Request resolved: #131844
@@ -799,7 +799,7 @@ std::tuple<Tensor, Tensor> _scaled_dot_product_attention_math(
attn.add_(*attn_mask);
}
}
attn = at::softmax(attn, -1);
attn = at::_safe_softmax(attn, -1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's happening :0

Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheee

drisspg added a commit that referenced this pull request Aug 6, 2024
ghstack-source-id: 82d15fe
Pull Request resolved: #131844
@drisspg drisspg closed this Aug 9, 2024
@github-actions github-actions bot deleted the gh/drisspg/16/head branch September 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: nn release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants