Skip to content

[dtensor][debug] adding js script to pytorch github so that i can host the browser visualizer on pytorch #132185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sinhaanshul
Copy link
Contributor

@sinhaanshul sinhaanshul commented Jul 30, 2024

Stack from ghstack (oldest at bottom):

Summary
This is the javascript portion that is used in CommDebugMode's visual browser. I have placed it here so that I can host the browser on PyTorch. I am following the same procedures to host as memory_viz https://github.com/pytorch/pytorch.github.io/blob/site/memory_viz.html

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132185

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 169e9a8 with merge base f389bca (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 30, 2024
sinhaanshul added a commit that referenced this pull request Jul 30, 2024
…t the browser visualizer on pytorch

ghstack-source-id: 1b17fbe
Pull Request resolved: #132185
@sinhaanshul sinhaanshul added the topic: not user facing topic category label Jul 30, 2024
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we cannot host it on pytorch webpage, do we have a backup plan? For example, land the .html file in this folder as well?

Context: @sinhaanshul created a web visualization for CommDebugMode output where users can drag and drop the trace file into a web page and view it. Right now the file is stored locally and we want to make it host on pytorch website just like https://github.com/pytorch/pytorch.github.io/blob/site/memory_viz.html so that users can use it without manually downloading the .htmland .js files. cc @wanchaol @tianyu-l @wz337

@sinhaanshul
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/sinhaanhsul/39/head branch September 1, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants