-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[MPS][BE] Delete MacOS-12.3 specific checks #133141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133141
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit fc11e04 with merge base 5a1d4f7 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
And make MPS device unavailabel on Sonoma releases As lots of those checks 2 years old, are no longer validated in CI and probably much more such checks are missing
51575d8
to
fc11e04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the cleanup.
@@ -26,8 +26,7 @@ namespace at::mps { | |||
|
|||
// Helper enum to check if a MPSGraph op is supported in a given macOS version | |||
enum class MacOSVersion : uint32_t { | |||
MACOS_VER_13_0_PLUS = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we removing support for 13.0 as well? I think stable one moves to 13.1 , so should be fine, but we don't need to remove it as part of this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, 13.0 is technically supported, but there are no need for enum value for it (same as we did not have an enum for 12.3, because it was supported by default)
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
@pytorchbot merge -f "All MacOS tests have passed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
#133141 updated min os requirement to 13.0, but missed the message
#133141 updated min os requirement to 13.0, but missed the message Fixes #139425 Pull Request resolved: #139427 Approved by: https://github.com/seemethere, https://github.com/kit1980
pytorch#133141 updated min os requirement to 13.0, but missed the message Fixes pytorch#139425 Pull Request resolved: pytorch#139427 Approved by: https://github.com/seemethere, https://github.com/kit1980
And make MPS device unavailable on Sonoma releases As lots of those checks 2 years old, are no longer validated in CI and probably much more such checks are missing