Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 9, 2024

And make MPS device unavailable on Sonoma releases As lots of those checks 2 years old, are no longer validated in CI and probably much more such checks are missing

@malfet malfet added topic: bc breaking topic category release notes: mps Release notes category labels Aug 9, 2024
@malfet malfet requested a review from kulinseth as a code owner August 9, 2024 23:09
Copy link

pytorch-bot bot commented Aug 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133141

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit fc11e04 with merge base 5a1d4f7 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Aug 9, 2024
And make MPS device unavailabel on Sonoma releases
As lots of those checks 2 years old, are no longer validated in CI and probably much more such checks are missing
@malfet malfet force-pushed the malfet/mps-to-support-macos-13-plus branch from 51575d8 to fc11e04 Compare August 14, 2024 00:14
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the cleanup.

@@ -26,8 +26,7 @@ namespace at::mps {

// Helper enum to check if a MPSGraph op is supported in a given macOS version
enum class MacOSVersion : uint32_t {
MACOS_VER_13_0_PLUS = 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing support for 13.0 as well? I think stable one moves to 13.1 , so should be fine, but we don't need to remove it as part of this PR ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 13.0 is technically supported, but there are no need for enum value for it (same as we did not have an enum for 12.3, because it was supported by default)

@malfet
Copy link
Contributor Author

malfet commented Aug 14, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 14, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Copy link
Contributor Author

malfet commented Aug 14, 2024

@pytorchbot merge -f "All MacOS tests have passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/mps-to-support-macos-13-plus branch September 17, 2024 01:57
jeongseok-meta added a commit to jeongseok-meta/pytorch-cpu-feedstock that referenced this pull request Oct 18, 2024
jeongseok-meta added a commit to jeongseok-meta/pytorch-cpu-feedstock that referenced this pull request Oct 25, 2024
malfet added a commit that referenced this pull request Oct 31, 2024
#133141 updated min os requirement to 13.0, but missed the message
pytorchmergebot pushed a commit that referenced this pull request Oct 31, 2024
#133141 updated min os requirement to 13.0, but missed the message

Fixes #139425

Pull Request resolved: #139427
Approved by: https://github.com/seemethere, https://github.com/kit1980
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
pytorch#133141 updated min os requirement to 13.0, but missed the message

Fixes pytorch#139425

Pull Request resolved: pytorch#139427
Approved by: https://github.com/seemethere, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: bc breaking topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants