Skip to content

Move FunctionSchema implementations to cpp file #133856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 19, 2024

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@meta.com

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133856

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit d951198 with merge base 907c32f (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 19, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: ba50cb5
Pull Request resolved: #133856
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you end up here because of binary size bloat or because you wanted to tweak and print and not wait 10 mins for a recompile 😛

@ezyang
Copy link
Contributor Author

ezyang commented Aug 19, 2024

I thought I wanted to tweak but it turns out I don't need to lol. Just some BE.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !
Some include needs tweaking

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 25, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 868b0cf
Pull Request resolved: #133856
@ezyang
Copy link
Contributor Author

ezyang commented Aug 25, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label Aug 26, 2024
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 26, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: ba8ea66
Pull Request resolved: #133856
@ezyang
Copy link
Contributor Author

ezyang commented Sep 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#133856
Approved by: https://github.com/bdhirsh, https://github.com/albanD
@github-actions github-actions bot deleted the gh/ezyang/2898/head branch October 2, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants