Skip to content

Check function declarations of Vulkan code #134550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Check function declarations of Vulkan code #134550

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 27, 2024

Fixes #ISSUE_NUMBER

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134550

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit e7a69ba with merge base f4641ca (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR module: vulkan release notes: vulkan release notes category labels Aug 27, 2024
@cyyever cyyever marked this pull request as draft August 27, 2024 04:14
@cyyever cyyever force-pushed the missing_include9 branch 10 times, most recently from 9887f29 to c8e9a16 Compare August 29, 2024 09:39
@cyyever cyyever marked this pull request as ready for review August 30, 2024 00:50
@cyyever cyyever requested a review from ezyang August 30, 2024 00:51
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 30, 2024
ezyang
ezyang reviewed Sep 1, 2024
View reviewed changes
aten/src/ATen/native/vulkan/api/Pipeline.cpp
@@ -230,7 +230,7 @@ void swap(ComputePipeline& lhs, ComputePipeline& rhs) noexcept {
rhs.handle_ = tmp_handle;
}

bool operator==(
static bool operator==(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty weird for equality to be static lol

ezyang
ezyang approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a decent chance some of these should have actually gotten headers, e.g., so they're accessible from gdb, but I'm guessing no one is going to complain

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot rebase main

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 1, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: main

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 1, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot rebase

@cyyever cyyever added the topic: not user facing topic category label Sep 1, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased missing_include9 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout missing_include9 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: periodic / ios-build-test / build (default, 1, 1, macos-14-xlarge, SIMULATOR, arm64, 1, 0, 1), periodic / buck-build-test / buck-build-test (default, 1, 1, ubuntu-latest), periodic / win-vs2019-cuda11.8-py3 / test (default, 2, 4, windows.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the missing_include9 branch September 2, 2024 09:59
tolleybot pushed a commit to tolleybot/pytorch that referenced this pull request Sep 14, 2024
@cyyever @tolleybot
Check function declarations of Vulkan code (pytorch#134550)
bfd49db 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#134550
Approved by: https://github.com/ezyang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@cyyever @Chao1Han
Check function declarations of Vulkan code (pytorch#134550)
063ec36 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#134550
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: vulkan open source release notes: vulkan release notes category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @pytorchmergebot @ezyang @pytorchbot @janeyx99