Allow optional positional arguments for torch.func.functional_call

[why-in-Shanghaitech]

This PR resolves #134408. Add an additional test and have passed the local test.

Do you think we should add a post-check to ensure args and kwargs are not both None? It seems to be possible to have modules without inputs.

This PR does not include any such post-check.

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134643

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0acaa6a with merge base 356f14e ():

NEW FAILURE - The following job has failed:

• trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) (gh)
  'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: why-in-Shanghaitech / name: Haoyi Wu (0acaa6a)

[zou3519]

Do you think we should add a post-check to ensure args and kwargs are not both None? It seems to be possible to have modules without inputs.

No, the module might not have any inputs.

[why-in-Shanghaitech]

When will this merge? I'm wondering whether it will appear in the next release. @zou3519

[zou3519]

@pytorchbot rebase

[zou3519]

BC lint seems erroneous, we are making a mandatory argument optional

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased my-nightly-branch onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout my-nightly-branch && git pull --rebase)

[zou3519]

@why-in-Shanghaitech if/when the tests pass, you can comment "@pytorchbot merge" and it'll merge the PR. Or I can do that, just comment on this thread again if you don't see it being merged

[why-in-Shanghaitech]

Oops... it seems that we have a time-out error...

[zou3519]

@pytorchbot merge -f "unrelated error"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here