Add Percentages to Function Events #135155
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135155
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3a5a3e2 with merge base a7a53b7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D62210351 |
sraikund16
added
ciflow/trunk
sraikund16
force-pushed
the
export-D62210351
branch
from
bd122d3 to
87bd95e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62210351 |
Summary: Pull Request resolved: pytorch#135155 Users have recently asked that the profiler contains self/total CPU and device percentages to FunctionEvents so that teams can process the data procedurely. Some of it could be done mathematically via subroutines but since we already have the information in the _build_table, lets build it there. Test Plan: Check that we have the same table as before but also check that the parameters we check also have the expected values Reviewed By: shanw-meta Differential Revision: D62210351
sraikund16
force-pushed
the
export-D62210351
branch
from
87bd95e to
3a5a3e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62210351 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
This PR needs to be approved by an authorized maintainer before merge. |
|
Approving to reconcile with already landed internal diff. |
|
@pytorchbot merge -f "landed internally" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Users have recently asked that the profiler contains self/total CPU and device percentages to FunctionEvents so that teams can process the data procedurely. Some of it could be done mathematically via subroutines but since we already have the information in the _build_table, lets build it there. Test Plan: Check that we have the same table as before but also check that the parameters we check also have the expected values Differential Revision: D62210351 Pull Request resolved: pytorch#135155 Approved by: https://github.com/shanw-meta, https://github.com/kit1980
Summary: Users have recently asked that the profiler contains self/total CPU and device percentages to FunctionEvents so that teams can process the data procedurely. Some of it could be done mathematically via subroutines but since we already have the information in the _build_table, lets build it there.
Test Plan: Check that we have the same table as before but also check that the parameters we check also have the expected values
Differential Revision: D62210351