Validate input types for torch.nn.Linear and torch.nn.Bilinear

[sanskarmodi8]

Adding validation checks to check the input types and display better error messages for the same.
Fixes #135463

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @malfet

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135596

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5834f1e with merge base e004d53 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[sanskarmodi8]

@pytorchbot label "topic: not user facing"

[malfet]

Please add unit tests and restrict your modifications to specific module, as this PR prevents anyone from extending the module and defining in_features as say floating point argument

[sanskarmodi8]

Please add unit tests and restrict your modifications to specific module, as this PR prevents anyone from extending the module and defining in_features as say floating point argument

Ok. I am working on these changes

[sanskarmodi8]

Hi @malfet,
I have made my changes specific to Linear and Bilinear module and implemented unit tests for the same as you requested.

[mikaylagawarecki]

change looks good, just need to move the test

[mikaylagawarecki]

looks like a lot of lines were changed due to your linter, can you undo your linting and use the pytorch lintrunner

make setup_lint, make quicklint from your pytorch folder

[sanskarmodi8]

looks like a lot of lines were changed due to your linter, can you undo your linting and use the pytorch lintrunner

make setup_lint, make quicklint from your pytorch folder

Thanks for reviewing, I have made the changes accordingly and pushed it.

[malfet]

LGTM, thank you for the fix

[malfet]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

[malfet]

@pytorchbot merge -f "Let's land those right away"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[sanskarmodi8]

@pytorchbot merge -f "Let's land those right away"

Hey @malfet ,
Is the PR is merged, it's not showing in the Pull Requests section in merged filter. It appears only in closed filter.

[malfet]

Is the PR is merged, it's not showing in the Pull Requests section in merged filter. It appears only in closed filter. !

It was not merged, but it's part of the trunk, see e157ce3

[sanskarmodi8]

Is the PR is merged, it's not showing in the Pull Requests section in merged filter. It appears only in closed filter. !

It was not merged, but it's part of the trunk, see e157ce3

Oh, ok.

[malfet]

@pytorchbot revert -m "It's too restrictive, should allow other int-like types"

[pytorch-bot]

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

[malfet]

@pytorchbot revert -m "It's too restrictive, should allow other int-like types, such as numpy.int64" -c weird

[pytorchmergebot]

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

[pytorchmergebot]

@sanskarmodi8 your PR has been successfully reverted.

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

[malfet]

I.e. things like that should work:

>>> torch.nn.Linear(np.array([1, 2, 3])[0], 2)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/nshulga/git/pytorch/pytorch/torch/nn/modules/linear.py", line 103, in __init__
    raise TypeError(f"Expected int for in_features but got {type(in_features)}")
TypeError: Expected int for in_features but got <class 'numpy.int64'>
>>> 

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.