Skip to content

Enable specifying of margin in HingeEmbeddingLoss #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Enable specifying of margin in HingeEmbeddingLoss #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion torch/nn/modules/loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,15 @@ class HingeEmbeddingLoss(_Loss):

The `margin` has a default value of `1`, or can be set in the constructor.
"""
pass

def __init__(self, margin=1.0, size_average=True):
super(HingeEmbeddingLoss, self).__init__()
self.margin = margin
self.size_average = size_average

def forward(self, input, target):
return self._backend.HingeEmbeddingLoss(self.margin,
self.size_average)(input, target)


class MultiLabelMarginLoss(_Loss):
Expand Down