Fix constant returning #137993

tugsbayasgalan · 2024-10-15T16:42:12Z

Stack from ghstack (oldest at bottom):

-> Fix constant returning #137993

When the constants are used twice in the exported graph (second one is returned as output), the lifting constant pass doesn't account for the second one being the output. THis PR fixes that.

Differential Revision: D64406108

Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) [ghstack-poisoned]

pytorch-bot · 2024-10-15T16:42:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137993

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 4a22b06 with merge base 47c8aa8 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-focal-py3.11-clang10 / test (default, 3, 4, lf.linux.4xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-focal-py3.12-clang10 / test (default, 3, 4, lf.linux.4xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, linux.4xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-focal-py3.9-clang10 / test (default, 3, 4, lf.linux.4xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, lf.linux.4xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 4, lf.linux.2xlarge) (gh) (trunk failure)
inductor/test_torchbind.py::TestTorchbind::test_torchbind_inductor

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-10-15T16:42:25Z

This pull request was exported from Phabricator. Differential Revision: D64406108

Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) ghstack-source-id: 248112285 Pull Request resolved: #137993

avikchaudhuri

Test please

When the constants are used twice in the exported graph (second one is returned as output), the lifting constant pass doesn't account for the second one being the output. THis PR fixes that. Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) [ghstack-poisoned]

Pull Request resolved: #137993 Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) ghstack-source-id: 248239733

facebook-github-bot · 2024-10-16T01:12:02Z

This pull request was exported from Phabricator. Differential Revision: D64406108

facebook-github-bot · 2024-10-16T06:52:55Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2024-10-16T06:55:06Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-16T12:53:47Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

tugsbayasgalan · 2024-10-16T16:40:19Z

@pytorchbot merge -f "Landed internally"

pytorchmergebot · 2024-10-16T16:42:01Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fix constant returning

8862e38

Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) [ghstack-poisoned]

tugsbayasgalan requested review from avikchaudhuri, zhxchen17, ydwu4 and angelayi as code owners October 15, 2024 16:42

pytorch-bot bot added ciflow/inductor release notes: export labels Oct 15, 2024

facebook-github-bot added the fb-exported label Oct 15, 2024

tugsbayasgalan added a commit that referenced this pull request Oct 15, 2024

Fix constant returning

ab498cd

Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) ghstack-source-id: 248112285 Pull Request resolved: #137993

avikchaudhuri requested changes Oct 15, 2024

View reviewed changes

tugsbayasgalan added a commit that referenced this pull request Oct 16, 2024

Fix constant returning

ee7e7b4

Pull Request resolved: #137993 Differential Revision: [D64406108](https://our.internmc.facebook.com/intern/diff/D64406108/) ghstack-source-id: 248239733

tugsbayasgalan requested a review from avikchaudhuri October 16, 2024 01:12

avikchaudhuri approved these changes Oct 16, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2024

pytorchmergebot added the merging label Oct 16, 2024

pytorchmergebot added the Merged label Oct 16, 2024

pytorchmergebot closed this in 0a6c40f Oct 16, 2024

pytorchmergebot removed the merging label Oct 16, 2024

github-actions bot deleted the gh/tugsbayasgalan/255/head branch November 16, 2024 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix constant returning #137993

Fix constant returning #137993

Uh oh!

tugsbayasgalan commented Oct 15, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

facebook-github-bot commented Oct 15, 2024

Uh oh!

avikchaudhuri left a comment

Uh oh!

facebook-github-bot commented Oct 16, 2024

Uh oh!

facebook-github-bot commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

tugsbayasgalan commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

Uh oh!

Fix constant returning #137993

Fix constant returning #137993

Uh oh!

Conversation

tugsbayasgalan commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137993

✅ You can merge normally! (8 Unrelated Failures)

Uh oh!

facebook-github-bot commented Oct 15, 2024

Uh oh!

avikchaudhuri left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Oct 16, 2024

Uh oh!

facebook-github-bot commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 16, 2024

Uh oh!

tugsbayasgalan commented Oct 16, 2024

Uh oh!

pytorchmergebot commented Oct 16, 2024

Merge started

Uh oh!

Uh oh!

tugsbayasgalan commented Oct 15, 2024 •

edited

Loading

pytorch-bot bot commented Oct 15, 2024 •

edited

Loading