[AOTI] Remove the non-ABI-compatible mode (part 1)

[desertfire]

Stack from ghstack (oldest at bottom):

• [AOTI] Remove the non-ABI-compatible mode (part 2) #138047
• -> [AOTI] Remove the non-ABI-compatible mode (part 1) #138009
• [AOTI] Remove explicit abi_compatible setting in tests #138016
• [AOTI] Remove non-ABI-compatible tests #137982

Summary: The ABI-compatible mode has been turned on as default in #136534. Removing the non-ABI-compatible logic to greatly simplify the wrapper codegen logic.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang

Differential Revision: D64439676

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138009

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1d0fe67 with merge base 966a1a9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[desertfire]

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[desertfire]

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[malfet]

Do you think it might be considered a BC breaking change? Or is aoti still a prototype?

[desertfire]

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[desertfire]

Do you think it might be considered a BC breaking change? Or is aoti still a prototype?

Are you referring to the fact that I am removing the abi_compatible flag? In general, I don't think we make any BC promise on Inductor control flags.

For the actual AOTI-generated code, there is no BC breakage because any previously generated model.so will continue to run. There is a FC implication, if a user is using an old version of pytorch at the deployment time, but the previous recommendation is to stick with the same version of pytorch for compile and deploy, so FC shouldn't be an issue either.

[chenyang78]

Nice!

[facebook-github-bot]

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here