fix ffs intrinsic for long long (ROCm 290) #13804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to __ffsll in Embedding which is the correct intrinsic here. * Fix WARP_BALLOT and ffsll in LookupTable as well.
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 10, 2018
Summary: * Switch to __ffsll in Embedding which is the correct intrinsic here. * Fix WARP_BALLOT and ffsll in LookupTable as well. Fix comes from iotamudelta Pull Request resolved: pytorch/pytorch#13804 Differential Revision: D13016184 Pulled By: bddppq fbshipit-source-id: 2287a78ee9e592630336a073ad1e55a90e1f946d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comes from @iotamudelta
#12899