Add c10 cuda library. #13900
Closed
Add c10 cuda library. #13900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13025313 Differential Version: 63437155
Differential Revision: D13025313 Differential Version: 63455020
Differential Revision: D13025313 Differential Version: 63458489
This was referenced Nov 13, 2018
Differential Revision: D13025313 Differential Version: 63651373
Differential Revision: D13025313 Differential Version: 63809737
This was referenced Nov 16, 2018
smessmer
approved these changes
Nov 16, 2018
c10/cuda/CMakeLists.txt
Outdated
| impl/*.cpp | ||
| impl/*.cu | ||
| ) | ||
| file(GLOB_RECURSE C10_CUDA_ALL_TEST_FILES test/*.cpp) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| set(test_name "c10_cuda_${test_file_name}") | ||
| add_executable(${test_name} "${test_src}") | ||
| target_link_libraries(${test_name} c10_cuda gtest_main) | ||
| add_test(NAME ${test_name} COMMAND $<TARGET_FILE:${test_name}>) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
TARGETS are in fbcode |
Differential Revision: D13025313 Differential Version: 63973996
Differential Revision: D13025313 Differential Version: 63974173
Differential Revision: D13025313 Differential Version: 63974553
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 19, 2018
Summary: Pull Request resolved: pytorch/pytorch#13900 Add c10 cuda library. Right now, this is not used by anything, and only tests if the CUDA headers are available (and not, e.g., that linking works.) Extra changes: - cmake/public/cuda.cmake now is correctly include guarded, so you can include it multiple times without trouble. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Reviewed By: smessmer Differential Revision: D13025313 fbshipit-source-id: fda85b4c35783ffb48ddd6bbb98dbd9154119d86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #13900 Add c10 cuda library. 💛
:white_circle: #13910 Move AT_CUDA_CHECK to c10 💛
:white_circle: #13912 Split out CUDAMultiStreamGuard from CUDAGuard 💛
:white_circle: #13920 Delete dependencies from CUDAStream; remove synchronize_with 💛
:white_circle: #14109 Move CUDAStreamInternals inside detail namespace. 💛
:white_circle: #14110 Move stream functions from CUDAContext to CUDAStream 💛
:white_circle: #14191 Add hash functions for Stream, CUDAStream; fix Device hash function 💛
Add c10 cuda library.
Right now, this is not used by anything, and only tests if the CUDA
headers are available (and not, e.g., that linking works.)
Extra changes:
can include it multiple times without trouble.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D13025313