Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Nov 9, 2024

Copy link

pytorch-bot bot commented Nov 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140211

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit f79cec6 with merge base dcc32ff (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: mps Release notes category labels Nov 9, 2024
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 9, 2024
@cyyever cyyever changed the title Env14 [Environment Variable][7/N] Use thread-safe getenv functions Nov 9, 2024
@cyyever cyyever requested a review from ezyang November 9, 2024 15:38
@cyyever cyyever force-pushed the env14 branch 2 times, most recently from 209b8e1 to 4f820fa Compare November 10, 2024 00:59
@ezyang
Copy link
Contributor

ezyang commented Nov 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I left this comment in the past, but there are no such thing as thread safe getenv. If someone will modify environment variable using POSIX setenv call, all of those changes will not protect PyTorch from returning gargbage

@ezyang
Copy link
Contributor

ezyang commented Nov 13, 2024

@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 3, 2025
…140211)"

This reverts commit 2fd1b6b.

Reverted #140211 on behalf of https://github.com/atalman due to Breaks executorch tests ([comment](#140211 (comment)))
@atalman
Copy link
Contributor

atalman commented Feb 3, 2025

Looks like following tests failing:
https://github.com/pytorch/executorch/blob/main/extension/aten_util/aten_bridge.cpp
https://github.com/pytorch/executorch/blob/main/extension/llm/sampler/sampler.cpp
https://github.com/pytorch/executorch/blob/main/extension/pytree/aten_util/test/ivalue_util_test.cpp

Error looks like:
libc++abi: terminating due to uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

mori360 pushed a commit to mori360/pytorch that referenced this pull request Feb 6, 2025
@cyyever cyyever added the module: cpp-extensions Related to torch.utils.cpp_extension label Feb 13, 2025
@github-actions github-actions bot closed this Mar 15, 2025
@cyyever cyyever reopened this Mar 15, 2025
@github-actions github-actions bot closed this Apr 14, 2025
@cyyever cyyever reopened this Apr 16, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Apr 24, 2025

@pytorchmergebot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpp-extensions Related to torch.utils.cpp_extension oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: mps Release notes category Reverted Stale test-config/executorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.