-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Environment Variable][7/N] Use thread-safe getenv functions #140211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140211
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit f79cec6 with merge base dcc32ff ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
209b8e1
to
4f820fa
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I left this comment in the past, but there are no such thing as thread safe getenv. If someone will modify environment variable using POSIX setenv call, all of those changes will not protect PyTorch from returning gargbage
@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs" |
@pytorchbot successfully started a revert job. Check the current status here. |
…140211)" This reverts commit 2fd1b6b. Reverted #140211 on behalf of https://github.com/atalman due to Breaks executorch tests ([comment](#140211 (comment)))
Looks like following tests failing: Error looks like: |
…#140211) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#140211 Approved by: https://github.com/ezyang, https://github.com/eqy
This reverts commit 551b7e5811c127be9f4210d9225606b111d69880.
@pytorchmergebot merge -f "Unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #ISSUE_NUMBER
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @malfet @zou3519 @xmfan