Skip to content

[AOTI] Add an option to skip optimizing generated wrapper code #144866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AOTI] Add an option to skip optimizing generated wrapper code #144866

wants to merge 1 commit into from

Conversation

desertfire
Copy link
Contributor

@desertfire desertfire commented Jan 15, 2025 •
edited by izaitsevfb
Loading

Summary: In some cases, generated wrapper code faces a long cpp compilation time. As an alleviation, this PR adds an option to skip cpp compiler optimizers for the generated main wrapper function body.

D68174038

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144866

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5d47b1f with merge base 926f905 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68174038

chenyang78
chenyang78 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 15, 2025
hl475
hl475 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@hl475 hl475 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@desertfire @facebook-github-bot
[AOTI] Add an option to skip optimizing generated wrapper code (#144866)
5d47b1f 
Summary:

In some cases, generated wrapper code faces a long cpp compilation time. As an alleviation, this PR adds an option to skip cpp compiler optimizers for the generated main wrapper function body.

Interstingly, an expriment that turns this on as default shows a reduction in compilation time without any noticable perf regression, https://hud.pytorch.org/benchmark/compilers?dashboard=torchinductor&startTime=Wed%2C%2008%20Jan%202025%2017%3A45%3A53%20GMT&stopTime=Wed%2C%2015%20Jan%202025%2017%3A45%3A53%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cpu%20(x86)&lBranch=export-D68174038&lCommit=29a1e91075e49be5656bc0ec69d81b0e8031b0f5&rBranch=main&rCommit=69b883d7ace02cb84a713c3a73e804ace1158eae

Test Plan: CI

Reviewed By: hl475, chenyang78

Differential Revision: D68174038
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68174038

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

@izaitsevfb
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Contributor

kit1980 commented Jan 18, 2025

@pytorchbot merge -f "Landed internally"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the export-D68174038 branch February 17, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@hl475 hl475 hl475 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor release notes: inductor topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@desertfire @facebook-github-bot @pytorchmergebot @izaitsevfb @kit1980 @chenyang78 @hl475