T34828131 : Fix tautological-compare in aten/src/ATen/native/cuda/SummaryOps.cu #14540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maryOps.cu Summary: refactor the HANDLE_SWITCH_CASE to avoid tautological-compare in macro Differential Revision: D13255725 fbshipit-source-id: 518ed77b8ebf0cf2ef6f2492ff981cbaba79e157
ezyang
approved these changes
Nov 29, 2018
|
nit: Don't put task numbers in the commit header, it's not useful for external contributors |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 29, 2018
…#14540) Summary: Pull Request resolved: pytorch/pytorch#14540 refactor the HANDLE_SWITCH_CASE to avoid tautological-compare in macro Reviewed By: ezyang Differential Revision: D13255725 fbshipit-source-id: cfa64bb7bc53d19c93a693015202f207567690b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: refactor the HANDLE_SWITCH_CASE to avoid tautological-compare in macro
Differential Revision: D13255725