[dynamo][functions] Support id on function
#145987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145987
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 1e426b4 with merge base 7796e30 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 30, 2025
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
anijain2305
requested review from
jansel,
StrongerXi,
mlazos and
williamwen42
StrongerXi
approved these changes
Jan 30, 2025
jansel
requested changes
Jan 30, 2025
torch/_dynamo/variables/builtin.py
Outdated
| @@ -1916,6 +1916,8 @@ def call_id(self, tx: "InstructionTranslator", *args): | |||
| elif len(args) == 1 and isinstance(args[0], TensorVariable): | |||
| tensor_variable = args[0] | |||
| return tensor_variable.call_id(tx) | |||
| elif isinstance(args[0], variables.UserFunctionVariable): | |||
There was a problem hiding this comment.
Suggested change
| elif isinstance(args[0], variables.UserFunctionVariable): | |
| elif istype(args[0], variables.UserFunctionVariable): |
You want to exclude UserMethodVariable, etc (which will have a different ID each time).
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
mlazos
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
jansel
approved these changes
Jan 31, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 31, 2025
Pull Request resolved: #145994 Approved by: https://github.com/StrongerXi, https://github.com/jansel ghstack dependencies: #145986, #145987
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 31, 2025
Pull Request resolved: #145989 Approved by: https://github.com/StrongerXi, https://github.com/jansel ghstack dependencies: #145986, #145987, #145994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
idon function #145987cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames