Skip to content

Add CUDA 12.8 windows nightly build #147037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Feb 12, 2025

#145570

windows AMI is deployed to prod today, prepping the windows cuda 12.8 build

cc @atalman @malfet @ptrblck @nWEIdia

@tinglvv tinglvv requested a review from a team as a code owner February 12, 2025 23:43
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 12, 2025
Copy link

pytorch-bot bot commented Feb 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147037

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures

As of commit ec7637e with merge base 655b061 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv tinglvv added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Feb 12, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Lets wait for green signal from CI before landing this change however

@tinglvv tinglvv changed the title Add cuda 12.8 windows nightly build Add CUDA 12.8 windows nightly build Feb 13, 2025
@tinglvv
Copy link
Collaborator Author

tinglvv commented Feb 18, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cu128-win-build onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cu128-win-build && git pull --rebase)

@tinglvv
Copy link
Collaborator Author

tinglvv commented Feb 19, 2025

@pytorchbot rebase

@tinglvv
Copy link
Collaborator Author

tinglvv commented Feb 19, 2025

failures are due to windows 12.8 not updated with correct NCCL version. Integrating #146073 and regenerating xml to use 2.25.1 NCCL. retriggering tests

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cu128-win-build onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cu128-win-build && git pull --rebase)

@atalman
Copy link
Contributor

atalman commented Feb 19, 2025

@pytorchmergebot merge -f "pr-sanity-check error is expected, other failures are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants