-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[dynamo] Ensure placeholder name is not an intermediate node name #149712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149712
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b28372b with merge base 0ed3421 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…de name" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as this doesn't cause a lot of expecttests to change
@pytorchbot mjerge |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This should be done by default but there are too many issues. This PR is a workaround. #117584 Pull Request resolved: #149758 Approved by: https://github.com/yf225 ghstack dependencies: #149712
…9758) This should be done by default but there are too many issues. This PR is a workaround. pytorch#117584 Pull Request resolved: pytorch#149758 Approved by: https://github.com/yf225 ghstack dependencies: pytorch#149712
Stack from ghstack (oldest at bottom):
Fixes https://fb.workplace.com/groups/1075192433118967/permalink/1615671879071017/
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames