Skip to content

[MPS] Add support for scaled_modified_bessel_k1 to eager. #149783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[MPS] Add support for scaled_modified_bessel_k1 to eager. #149783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions aten/src/ATen/native/mps/kernels/SpecialOps.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ DEFINE_UNARY_FLOATING_FUNCTOR(modified_bessel_i1_forward);
DEFINE_UNARY_FLOATING_FUNCTOR(modified_bessel_k0_forward);
DEFINE_UNARY_FLOATING_FUNCTOR(modified_bessel_k1_forward);
DEFINE_UNARY_FLOATING_FUNCTOR(scaled_modified_bessel_k0_forward);
DEFINE_UNARY_FLOATING_FUNCTOR(scaled_modified_bessel_k1_forward);
DEFINE_UNARY_FLOATING_FUNCTOR(i0);
DEFINE_UNARY_FLOATING_FUNCTOR(i0e);
DEFINE_UNARY_FLOATING_FUNCTOR(i1);
Expand Down Expand Up @@ -57,6 +58,7 @@ struct bessel_y1_forward_functor {
REGISTER_UNARY_OP(modified_bessel_k0_forward, DTI, DTO); \
REGISTER_UNARY_OP(modified_bessel_k1_forward, DTI, DTO); \
REGISTER_UNARY_OP(scaled_modified_bessel_k0_forward, DTI, DTO); \
REGISTER_UNARY_OP(scaled_modified_bessel_k1_forward, DTI, DTO); \
REGISTER_UNARY_OP(bessel_y0_forward, DTI, DTO); \
REGISTER_UNARY_OP(bessel_y1_forward, DTI, DTO); \
REGISTER_UNARY_OP(i0, DTI, DTO); \
Expand Down
5 changes: 5 additions & 0 deletions aten/src/ATen/native/mps/operations/SpecialOps.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ static void scaled_modified_bessel_k0_kernel_mps(TensorIteratorBase& iter) {
lib.exec_unary_kernel(iter, "scaled_modified_bessel_k0_forward");
}

static void scaled_modified_bessel_k1_kernel_mps(TensorIteratorBase& iter) {
lib.exec_unary_kernel(iter, "scaled_modified_bessel_k1_forward");
}

static void bessel_y0_kernel_mps(TensorIteratorBase& iter) {
lib.exec_unary_kernel(iter, "bessel_y0_forward");
}
Expand All @@ -83,6 +87,7 @@ static void bessel_y1_kernel_mps(TensorIteratorBase& iter) {
REGISTER_DISPATCH(special_modified_bessel_k0_stub, &modified_bessel_k0_kernel_mps)
REGISTER_DISPATCH(special_modified_bessel_k1_stub, &modified_bessel_k1_kernel_mps)
REGISTER_DISPATCH(special_scaled_modified_bessel_k0_stub, &scaled_modified_bessel_k0_kernel_mps)
REGISTER_DISPATCH(special_scaled_modified_bessel_k1_stub, &scaled_modified_bessel_k1_kernel_mps)
REGISTER_DISPATCH(special_bessel_y0_stub, &bessel_y0_kernel_mps)
REGISTER_DISPATCH(special_bessel_y1_stub, &bessel_y1_kernel_mps)
REGISTER_DISPATCH(special_spherical_bessel_j0_stub, &spherical_bessel_j0_kernel_mps)
Expand Down
2 changes: 1 addition & 1 deletion aten/src/ATen/native/native_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15516,7 +15516,7 @@

- func: special_scaled_modified_bessel_k1.out(Tensor x, *, Tensor(a!) out) -> Tensor(a!)
dispatch:
CPU, CUDA: special_scaled_modified_bessel_k1_out
CPU, CUDA, MPS: special_scaled_modified_bessel_k1_out
python_module: special
structured_inherits: TensorIteratorBase
structured: True
Expand Down
68 changes: 68 additions & 0 deletions c10/metal/special_math.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1455,5 +1455,73 @@ inline float scaled_modified_bessel_k0_forward(T x) {
return 0.5 * (b - p) / ::metal::precise::sqrt(x);
}

template <typename T>
inline float scaled_modified_bessel_k1_forward(T x) {
constexpr float A[] = {
-7.02386347938628759343e-18,
-2.42744985051936593393e-15,
-6.66690169419932900609e-13,
-1.41148839263352776110e-10,
-2.21338763073472585583e-08,
-2.43340614156596823496e-06,
-1.73028895751305206302e-04,
-6.97572385963986435018e-03,
-1.22611180822657148235e-01,
-3.53155960776544875667e-01,
+1.52530022733894777053e+00,
};

constexpr float B[] = {
-5.75674448366501715755e-18, +1.79405087314755922667e-17,
-5.68946255844285935196e-17, +1.83809354436663880070e-16,
-6.05704724837331885336e-16, +2.03870316562433424052e-15,
-7.01983709041831346144e-15, +2.47715442448130437068e-14,
-8.97670518232499435011e-14, +3.34841966607842919884e-13,
-1.28917396095102890680e-12, +5.13963967348173025100e-12,
-2.12996783842756842877e-11, +9.21831518760500529508e-11,
-4.19035475934189648750e-10, +2.01504975519703286596e-09,
-1.03457624656780970260e-08, +5.74108412545004946722e-08,
-3.50196060308781257119e-07, +2.40648494783721712015e-06,
-1.93619797416608296024e-05, +1.95215518471351631108e-04,
-2.85781685962277938680e-03, +1.03923736576817238437e-01,
+2.72062619048444266945e+00,
};

if (x == 0.0) {
return INFINITY;
}

if (x < 0.0) {
return NAN;
}

float p;
float q = 0.0;

if (x <= 2.0) {
float a = A[0];

for (uint8_t index = 1; index < 11; index++) {
p = q;
q = a;
a = (x * x - 2.0) * q - p + A[index];
}

return (::metal::precise::log(0.5 * x) * modified_bessel_i1_forward(x) +
0.5 * (a - p) / x) *
::metal::precise::exp(x);
}

float b = B[0];

for (uint8_t index = 1; index < 25; index++) {
p = q;
q = b;
b = (8.0 / x - 2.0) * q - p + B[index];
}

return (0.5 * (b - p) / ::metal::precise::sqrt(x));
}

} // namespace metal
} // namespace c10
1 change: 0 additions & 1 deletion test/test_mps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,6 @@ def mps_ops_modifier(ops):
'special.laguerre_polynomial_l': None,
'special.log_ndtr': None,
'special.ndtri': None,
'special.scaled_modified_bessel_k1': None,
'svd_lowrank': None,
'symeig': None,
'take': None,
Expand Down
Loading