[dynamo] add reason field to torch.compiler.disable #150341

williamwen42 · 2025-03-31T20:43:53Z

Stack from ghstack (oldest at bottom):

Implements #146445

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2025-03-31T20:43:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150341

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit 3c25237 with merge base 0d44a8a ():

NEW FAILURES - The following jobs have failed:

inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh)
densenet121
linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh)
Process completed with exit code 1.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh) (#149370)
REGRESSION: benchmark ('aotdispatcher_training_nosubclass_cpu', 'compile_time_instruction_count') failed, actual result 3636142742 is 1.60% higher than expected 3579000000 ±+1.50% if this is an expected regression, please update the expected results.
pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.ephemeral.linux.2xlarge) (gh) (#144480)
Process completed with exit code 1.
pull / linux-jammy-xpu-2025.0-py3.9 / build (gh) (#150430)
/usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/sstream:152:52: error: expected value in expression

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 6b5c538 Pull Request resolved: #150341

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 7783041 Pull Request resolved: #150341

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: db17776 Pull Request resolved: #150341

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: db283c1 Pull Request resolved: #150341

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: ba2bc49 Pull Request resolved: #150341

zou3519 · 2025-04-01T02:48:24Z

test/dynamo/test_error_messages.py

+
+        mod = Mod()
+        mod.compile()
+        mod = torch.compiler.disable(mod, reason="test message 2")


What are the chances you can go around the codebase and add reasons for all of the torch.compiler.disables? Maybe even codemod a bunch of them to message=None if it's too difficult to human-write one.

It'll be easier for people to cargo-cult a message in if existing code looks that way already

Done in a followup

zou3519 · 2025-04-01T18:28:32Z

torch/compiler/__init__.py

@@ -228,18 +228,19 @@ def assume_constant_result(fn):
    return torch._dynamo.assume_constant_result(fn)


-def disable(fn=None, recursive=True):
+def disable(fn=None, recursive=True, reason=None):


maybe kwarg-only the reason: (fn=None, recursive=True, *, reason=None)

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

williamwen42 · 2025-04-01T22:47:17Z

@pytorchbot merge

pytorchmergebot · 2025-04-01T22:48:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-01T22:49:26Z

Starting merge as part of PR stack under #150440

pytorchmergebot · 2025-04-02T01:00:13Z

Merge failed

Reason: 2 jobs have failed, first few of them are: inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team

Raised by workflow job

pytorchmergebot · 2025-04-02T04:21:02Z

Starting merge as part of PR stack under #150440

Pull Request resolved: #150440 Approved by: https://github.com/jansel, https://github.com/zou3519 ghstack dependencies: #150341

Implements pytorch#146445 Pull Request resolved: pytorch#150341 Approved by: https://github.com/zou3519, https://github.com/jansel

Pull Request resolved: pytorch#150440 Approved by: https://github.com/jansel, https://github.com/zou3519 ghstack dependencies: pytorch#150341

ghstack-source-id: 6a8eb80 Pull Request resolved: pytorch/pytorch#150341

[dynamo] add messages torch.compiler.disable

e0e903b

[ghstack-poisoned]

williamwen42 mentioned this pull request Mar 31, 2025

[dynamo] add error message for unsupported LOAD_BUILD_CLASS #150323

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels Mar 31, 2025

williamwen42 added a commit that referenced this pull request Mar 31, 2025

[dynamo] add messages torch.compiler.disable

7298551

ghstack-source-id: 6b5c538 Pull Request resolved: #150341

Update on "[dynamo] add messages torch.compiler.disable"

bd56168

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Mar 31, 2025

[dynamo] add messages torch.compiler.disable

38cc52e

ghstack-source-id: 7783041 Pull Request resolved: #150341

williamwen42 added release notes: dynamo module: compile ux UX issues related to torch.compile labels Mar 31, 2025

williamwen42 changed the title ~~[dynamo] add messages torch.compiler.disable~~ [dynamo] add reason field to torch.compiler.disable Mar 31, 2025

Update on "[dynamo] add reason field to torch.compiler.disable"

33ac485

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Mar 31, 2025

[dynamo] add messages torch.compiler.disable

3a55990

ghstack-source-id: db17776 Pull Request resolved: #150341

Update on "[dynamo] add reason field to torch.compiler.disable"

5fa41cc

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Mar 31, 2025

[dynamo] add messages torch.compiler.disable

201dbac

ghstack-source-id: db283c1 Pull Request resolved: #150341

Update on "[dynamo] add reason field to torch.compiler.disable"

a8adc6b

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Mar 31, 2025

[dynamo] add messages torch.compiler.disable

ffae02d

ghstack-source-id: ba2bc49 Pull Request resolved: #150341

williamwen42 requested review from jansel, anijain2305, zou3519, xmfan and StrongerXi April 1, 2025 02:10

zou3519 reviewed Apr 1, 2025

View reviewed changes

williamwen42 mentioned this pull request Apr 1, 2025

[dynamo] add dynamo disable reasons to codebase #150440

Closed

zou3519 approved these changes Apr 1, 2025

View reviewed changes

jansel approved these changes Apr 1, 2025

View reviewed changes

williamwen42 added 2 commits April 1, 2025 14:11

Update on "[dynamo] add reason field to torch.compiler.disable"

d5f7cb0

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[dynamo] add reason field to torch.compiler.disable"

3c25237

Implements #146445 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 1, 2025

pytorchmergebot added the merging label Apr 1, 2025

pytorchmergebot removed the merging label Apr 2, 2025

pytorchmergebot closed this in 25eff6e Apr 2, 2025

pytorchmergebot added the Merged label Apr 2, 2025

pytorchmergebot pushed a commit that referenced this pull request Apr 2, 2025

[dynamo] add dynamo disable reasons to codebase (#150440)

3ac5a49

Pull Request resolved: #150440 Approved by: https://github.com/jansel, https://github.com/zou3519 ghstack dependencies: #150341

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025

[dynamo] add messages torch.compiler.disable

eb60aeb

ghstack-source-id: 6a8eb80 Pull Request resolved: pytorch/pytorch#150341

github-actions bot deleted the gh/williamwen42/224/head branch May 12, 2025 02:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dynamo] add reason field to torch.compiler.disable #150341

[dynamo] add reason field to torch.compiler.disable #150341

Uh oh!

williamwen42 commented Mar 31, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

zou3519 Apr 1, 2025

Uh oh!

williamwen42 Apr 1, 2025

Uh oh!

zou3519 Apr 1, 2025

Uh oh!

williamwen42 commented Apr 1, 2025

Uh oh!

pytorchmergebot commented Apr 1, 2025

Uh oh!

pytorchmergebot commented Apr 1, 2025

Uh oh!

pytorchmergebot commented Apr 2, 2025

Uh oh!

pytorchmergebot commented Apr 2, 2025

Uh oh!

Uh oh!

[dynamo] add reason field to torch.compiler.disable #150341

[dynamo] add reason field to torch.compiler.disable #150341

Uh oh!

Conversation

williamwen42 commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150341

❌ 2 New Failures, 5 Unrelated Failures

Uh oh!

zou3519 Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

williamwen42 Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

zou3519 Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

williamwen42 commented Apr 1, 2025

Uh oh!

pytorchmergebot commented Apr 1, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 1, 2025

Uh oh!

pytorchmergebot commented Apr 2, 2025

Merge failed

Uh oh!

pytorchmergebot commented Apr 2, 2025

Uh oh!

Uh oh!

williamwen42 commented Mar 31, 2025 •

edited

Loading

pytorch-bot bot commented Mar 31, 2025 •

edited

Loading