[map] always turn on dynamo for map #150962

ydwu4 · 2025-04-09T21:42:33Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2025-04-09T21:42:36Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150962

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit a378223 with merge base 1250106 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.8xlarge.amx) (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 4fcbbc6 Pull Request resolved: #150962

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 0576853 Pull Request resolved: #150962

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

pytorchmergebot · 2025-04-11T20:55:21Z

Starting merge as part of PR stack under #151034

pytorchmergebot · 2025-04-11T21:21:44Z

Starting merge as part of PR stack under #151034

Pull Request resolved: #151034 Approved by: https://github.com/zou3519 ghstack dependencies: #150962

Camyll · 2025-04-14T21:05:57Z

@pytorchbot revert

pytorch-bot · 2025-04-14T21:06:00Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message, -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

Camyll · 2025-04-14T21:07:30Z

@pytorchbot revert -m "breaking internal builds by failing 4 tests" -c ghfirst

pytorchmergebot · 2025-04-14T21:09:09Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit ca2e8cd. Reverted #151034 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](#150962 (comment)))

This reverts commit a72d56c. Reverted #150962 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](#150962 (comment)))

pytorchmergebot · 2025-04-14T21:09:29Z

@ydwu4 your PR has been successfully reverted.

Pull Request resolved: pytorch#150962 Approved by: https://github.com/zou3519

Pull Request resolved: pytorch#151034 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#150962

This reverts commit ca2e8cd. Reverted pytorch#151034 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](pytorch#150962 (comment)))

This reverts commit a72d56c. Reverted pytorch#150962 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](pytorch#150962 (comment)))

Pull Request resolved: pytorch#150962 Approved by: https://github.com/zou3519

Pull Request resolved: pytorch#151034 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#150962

This reverts commit ca2e8cd. Reverted pytorch#151034 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](pytorch#150962 (comment)))

This reverts commit a72d56c. Reverted pytorch#150962 on behalf of https://github.com/Camyll due to breaking internal builds {SHORT_REASON} ([comment](pytorch#150962 (comment)))

ghstack-source-id: e21aeb5 Pull Request resolved: pytorch/pytorch#150962

Summary: X-link: pytorch/executorch#10409 Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519 Differential Revision: D73138427

Summary: X-link: pytorch/executorch#10409 Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427

Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427

ydwu4 · 2025-05-05T20:13:01Z

Replaced by #152041

Summary: Reland D72896450 Make map consistent with other control flow ops. After the change, map is able to support accessing closures in the map fn. Test Plan: See existing tests. Reviewed By: zou3519, angelayi Differential Revision: D73138427

[map] always turn on dynamo for map

cdd1d2b

[ghstack-poisoned]

ydwu4 requested a review from zou3519 as a code owner April 9, 2025 21:42

pytorch-bot bot added ciflow/inductor module: dynamo labels Apr 9, 2025

ydwu4 added a commit that referenced this pull request Apr 9, 2025

[map] always turn on dynamo for map

2aba4d8

ghstack-source-id: 4fcbbc6 Pull Request resolved: #150962

Update on "[map] always turn on dynamo for map"

f263595

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ydwu4 added a commit that referenced this pull request Apr 9, 2025

[map] always turn on dynamo for map

8c5b793

ghstack-source-id: 0576853 Pull Request resolved: #150962

ydwu4 mentioned this pull request Apr 10, 2025

[map] add inductor support by lowering to while_loop #150971

Closed

Update on "[map] always turn on dynamo for map"

1b26703

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ydwu4 mentioned this pull request Apr 10, 2025

[map] make proxy mode re-dispatch to fake key #151034

Closed

ydwu4 added the keep-going Don't stop on first failure, keep running tests until the end label Apr 10, 2025

ydwu4 added 2 commits April 10, 2025 13:47

Update on "[map] always turn on dynamo for map"

f92b1f0

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[map] always turn on dynamo for map"

b10c034

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ydwu4 added the topic: not user facing topic category label Apr 10, 2025

zou3519 approved these changes Apr 10, 2025

View reviewed changes

ydwu4 added 3 commits April 11, 2025 09:35

Update on "[map] always turn on dynamo for map"

72a6ea6

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[map] always turn on dynamo for map"

72af745

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[map] always turn on dynamo for map"

a378223

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ydwu4 requested review from ezyang and Chillee as code owners April 11, 2025 18:17

pytorchmergebot closed this in a72d56c Apr 11, 2025

pytorchmergebot pushed a commit that referenced this pull request Apr 11, 2025

[map] make proxy mode re-dispatch to fake key (#151034)

ca2e8cd

Pull Request resolved: #151034 Approved by: https://github.com/zou3519 ghstack dependencies: #150962

pytorchmergebot added the Merged label Apr 11, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Apr 14, 2025

pytorchmergebot reopened this Apr 14, 2025

timocafe pushed a commit to timocafe/pytorch that referenced this pull request Apr 16, 2025

[map] always turn on dynamo for map (pytorch#150962)

b4da55e

Pull Request resolved: pytorch#150962 Approved by: https://github.com/zou3519

timocafe pushed a commit to timocafe/pytorch that referenced this pull request Apr 16, 2025

[map] make proxy mode re-dispatch to fake key (pytorch#151034)

9a91807

Pull Request resolved: pytorch#151034 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#150962

amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025

[map] always turn on dynamo for map (pytorch#150962)

bd6d438

Pull Request resolved: pytorch#150962 Approved by: https://github.com/zou3519

amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025

[map] make proxy mode re-dispatch to fake key (pytorch#151034)

ac21cc9

Pull Request resolved: pytorch#151034 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#150962

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025

[map] always turn on dynamo for map

23785b3

ghstack-source-id: e21aeb5 Pull Request resolved: pytorch/pytorch#150962

ydwu4 closed this May 5, 2025

github-actions bot deleted the gh/ydwu4/229/head branch June 7, 2025 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[map] always turn on dynamo for map #150962

[map] always turn on dynamo for map #150962

Uh oh!

ydwu4 commented Apr 9, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

pytorchmergebot commented Apr 11, 2025

Uh oh!

pytorchmergebot commented Apr 11, 2025

Uh oh!

Camyll commented Apr 14, 2025

Uh oh!

pytorch-bot bot commented Apr 14, 2025

Uh oh!

Camyll commented Apr 14, 2025 •

edited

Loading

Uh oh!

pytorchmergebot commented Apr 14, 2025

Uh oh!

pytorchmergebot commented Apr 14, 2025

Uh oh!

ydwu4 commented May 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

[map] always turn on dynamo for map #150962

[map] always turn on dynamo for map #150962

Uh oh!

Conversation

ydwu4 commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150962

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

pytorchmergebot commented Apr 11, 2025

Uh oh!

pytorchmergebot commented Apr 11, 2025

Uh oh!

Camyll commented Apr 14, 2025

Uh oh!

pytorch-bot bot commented Apr 14, 2025

Uh oh!

Camyll commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorchmergebot commented Apr 14, 2025

Uh oh!

pytorchmergebot commented Apr 14, 2025

Uh oh!

ydwu4 commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ydwu4 commented Apr 9, 2025 •

edited

Loading

pytorch-bot bot commented Apr 9, 2025 •

edited

Loading

Camyll commented Apr 14, 2025 •

edited

Loading

ydwu4 commented May 5, 2025 •

edited

Loading