c10d/Store: add clone feature #150966
Closed
c10d/Store: add clone feature #150966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150966
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 914c66a with merge base d751698 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
fduwjj
approved these changes
Apr 9, 2025
|
@fduwjj yes, I'm referring to the check call -- with this change we could instead do the more efficient |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@d4l3k the non-blocking check is actually intentional because it also checks the heartbeat. Or maybe we are ok with a third thread which only dumps FR and this thread is going to be class member. |
|
@pytorchmergebot revert -c ghfirst -m "failing internally" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Apr 10, 2025
This reverts commit 205881e. Reverted #150966 on behalf of https://github.com/atalman due to failing internally ([comment](#150966 (comment)))
|
@d4l3k your PR has been successfully reverted. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
Summary: This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: #150943 Approved by: https://github.com/fduwjj Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/205881ea4a451574c3a3de87c42484043a955d6e Test plan from GitHub: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Differential Revision: D72789690
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 11, 2025
Summary: This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: #150943 Approved by: https://github.com/fduwjj Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/205881ea4a451574c3a3de87c42484043a955d6e Test plan from GitHub: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Differential Revision: D72789690 Pull Request resolved: #151045 Approved by: https://github.com/XilunWu, https://github.com/fduwjj
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: pytorch#150943 Test plan: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Pull Request resolved: pytorch#150966 Approved by: https://github.com/fduwjj
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
This reverts commit 205881e. Reverted pytorch#150966 on behalf of https://github.com/atalman due to failing internally ([comment](pytorch#150966 (comment)))
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
…rch#151045) Summary: This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: pytorch#150943 Approved by: https://github.com/fduwjj Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/205881ea4a451574c3a3de87c42484043a955d6e Test plan from GitHub: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Differential Revision: D72789690 Pull Request resolved: pytorch#151045 Approved by: https://github.com/XilunWu, https://github.com/fduwjj
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: pytorch#150943 Test plan: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Pull Request resolved: pytorch#150966 Approved by: https://github.com/fduwjj
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
This reverts commit 205881e. Reverted pytorch#150966 on behalf of https://github.com/atalman due to failing internally ([comment](pytorch#150966 (comment)))
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…rch#151045) Summary: This adds a new `clone()` method to Store which will return a new Store instance that can be used from a different thread. This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation. Related issue: pytorch#150943 Approved by: https://github.com/fduwjj Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/205881ea4a451574c3a3de87c42484043a955d6e Test plan from GitHub: ``` pytest test/distributed/test_store.py -k PythonStore pytest test/distributed/test_store.py -k clone ``` Differential Revision: D72789690 Pull Request resolved: pytorch#151045 Approved by: https://github.com/XilunWu, https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
clone()method to Store which will return a new Store instance that can be used from a different thread.This is intended to better support multiple threads with stores such as when ProcessGroupNCCL needs a store to do error propagation.
Related issue: #150943
Test plan:
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab