Skip to content

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Apr 10, 2025

This pull request introduces a new method to convert VerificationInfo objects to dictionaries and includes a corresponding test to ensure the method works correctly.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 10, 2025
Copy link

pytorch-bot bot commented Apr 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151024

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2132ee3 with merge base 1250106 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby justinchuby added module: onnx Related to torch.onnx topic: improvements topic category labels Apr 10, 2025
@justinchuby justinchuby changed the title Add asdict method to VerificationInfo class [ONNX] Add asdict method to VerificationInfo class Apr 10, 2025
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to have another test that covers serializing to json?

@justinchuby
Copy link
Collaborator Author

Would it be helpful to have another test that covers serializing to json?

Done

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby deleted the justinchu/add-asdict-method branch April 10, 2025 23:18
timocafe pushed a commit to timocafe/pytorch that referenced this pull request Apr 16, 2025
This pull request introduces a new method to convert `VerificationInfo` objects to dictionaries and includes a corresponding test to ensure the method works correctly.

Pull Request resolved: pytorch#151024
Approved by: https://github.com/titaiwangms
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
This pull request introduces a new method to convert `VerificationInfo` objects to dictionaries and includes a corresponding test to ensure the method works correctly.

Pull Request resolved: pytorch#151024
Approved by: https://github.com/titaiwangms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants