[ONNX] Update decomposition logic to loop over onnx registry #151826
Conversation
titaiwangms
requested review from
shubhambhokare1,
justinchuby and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151826
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 47618d2 with merge base cea43f7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
|
Should we update |
|
Actually: We use str for all aten ops because they are sometimes not the same objects. Need to use logic to recover the aten ops. You can probably use getattr to do that. |
|
Need to update the logic in ? |
Should be fine. That's why I am taking fx_target from OnnxDecompMeta. |
|
Makes sense. I confused myself |
titaiwangms
added
module: onnx
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7.1 -c critical |
Cherry picking #151826Command Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
Fixes #150367 This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export. Pull Request resolved: #151826 Approved by: https://github.com/justinchuby (cherry picked from commit 6cd1741)
Cherry picking #151826The cherry pick PR is at #153168 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
* [ONNX] Update decomposition logic to loop over onnx registry (#151826) Fixes #150367 This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export. Pull Request resolved: #151826 Approved by: https://github.com/justinchuby (cherry picked from commit 6cd1741) * [ONNX] Add test for decomp_table update (#153671) Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby --------- Co-authored-by: titaiwangms <titaiwang@microsoft.com>
Fixes #150367
This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export.